Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] libnfc: make example build optional
Date: Tue, 05 Jun 2012 23:25:54 +0200	[thread overview]
Message-ID: <8762b5pi1p.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <1338741337-12019-1-git-send-email-s.martin49@gmail.com> (Samuel Martin's message of "Sun, 3 Jun 2012 18:35:37 +0200")

>>>>> "Samuel" == Samuel Martin <s.martin49@gmail.com> writes:

 Samuel> This patch converts libnfc to CMAKETARGET and makes example build
 Samuel> optional.

What's the reason for using cmake instead of autotools? Is upstream
moving away from autotools or is it just because you prefer cmake?


 Samuel> Fixes http://autobuild.buildroot.org/results/a963924b15e185d0144809a98feac52dec0d1cc3
 Samuel> Signed-off-by: Samuel Martin <s.martin49@gmail.com>

 Samuel> diff --git a/package/libnfc/libnfc-make-examples-optional.patch b/package/libnfc/libnfc-make-examples-optional.patch
 Samuel> new file mode 100644
 Samuel> index 0000000..da8bc3f
 Samuel> --- /dev/null
 Samuel> +++ b/package/libnfc/libnfc-make-examples-optional.patch

Please add a git-style header with description and your signed-off-by to
this patch. Have you submitted it upstream? If not, please consider
doing so.


 Samuel> @@ -0,0 +1,22 @@
 Samuel> +--- libnfc-1.5.1.orig/CMakeLists.txt	2012-06-03 17:57:20.308085744 +0200
 Samuel> ++++ libnfc-1.5.1/CMakeLists.txt	2012-06-03 18:13:37.502570332 +0200
 Samuel> +@@ -27,6 +27,7 @@ INCLUDE_DIRECTORIES(${CMAKE_CURRENT_SOUR
 Samuel> + SET(CMAKE_MODULE_PATH "${CMAKE_SOURCE_DIR}/cmake/modules/")
 Samuel> + 
 Samuel> + # Options
 Samuel> ++SET(BUILD_EXAMPLES OFF CACHE BOOL "Build examples")
 Samuel> + SET(LIBNFC_DEBUG_OUTPUT OFF CACHE BOOL "Debug output of communication with the NFC chip")
 Samuel> + IF(LIBNFC_DEBUG_OUTPUT)
 Samuel> +   ADD_DEFINITIONS(-DDEBUG -g3)
 Samuel> +@@ -101,7 +102,10 @@ ENDIF(LIBUSB_INCLUDE_DIRS)
 Samuel> + ADD_SUBDIRECTORY(libnfc)
 Samuel> + ADD_SUBDIRECTORY(include)
 Samuel> + ADD_SUBDIRECTORY(utils)
 Samuel> +-ADD_SUBDIRECTORY(examples)
 Samuel> ++
 Samuel> ++IF(BUILD_EXAMPLES)
 Samuel> ++  ADD_SUBDIRECTORY(examples)
 Samuel> ++ENDIF(BUILD_EXAMPLES)
 Samuel> + 
 Samuel> + # Binary Package
 Samuel> + IF(WIN32)

-- 
Bye, Peter Korsgaard

  reply	other threads:[~2012-06-05 21:25 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-03 16:35 [Buildroot] [PATCH 1/1] libnfc: make example build optional Samuel Martin
2012-06-05 21:25 ` Peter Korsgaard [this message]
2012-06-05 23:37   ` Samuel Martin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8762b5pi1p.fsf@macbook.be.48ers.dk \
    --to=jacmet@uclibc.org \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox