From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 3/5] mesa3d: add patch to fix build on !locale toolchains
Date: Wed, 05 Oct 2011 20:02:55 +0200 [thread overview]
Message-ID: <8762k3pb8w.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <f08b73124ef8e797878851102a0f915e06dc4fd1.1316465857.git.thomas.petazzoni@free-electrons.com> (Thomas Petazzoni's message of "Mon, 19 Sep 2011 22:57:39 +0200")
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:
Thomas> Fixes bug #3313.
Thomas> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Thomas> ---
Thomas> .../x11r7/mesa3d/mesa3d-7.6.1-fix-no-locale.patch | 14 ++++++++++++++
Thomas> 1 files changed, 14 insertions(+), 0 deletions(-)
Thomas> create mode 100644 package/x11r7/mesa3d/mesa3d-7.6.1-fix-no-locale.patch
Thomas> diff --git a/package/x11r7/mesa3d/mesa3d-7.6.1-fix-no-locale.patch b/package/x11r7/mesa3d/mesa3d-7.6.1-fix-no-locale.patch
Thomas> new file mode 100644
Thomas> index 0000000..6b481d2
Thomas> --- /dev/null
Thomas> +++ b/package/x11r7/mesa3d/mesa3d-7.6.1-fix-no-locale.patch
Thomas> @@ -0,0 +1,14 @@
Thomas> +Index: Mesa-7.6.1/src/mesa/main/imports.c
Thomas> +===================================================================
Thomas> +--- Mesa-7.6.1.orig/src/mesa/main/imports.c
Thomas> ++++ Mesa-7.6.1/src/mesa/main/imports.c
Thomas> +@@ -915,7 +915,8 @@
Thomas> + double
Thomas> + _mesa_strtod( const char *s, char **end )
Thomas> + {
Thomas> +-#ifdef _GNU_SOURCE
Thomas> ++ /* We need either a glibc/eglibc library, or uClibc with locales */
Thomas> ++#if defined(_GNU_SOURCE) && (!defined(__UCLIBC__) || defined(__UCLIBC_HAS_LOCALE__))
I didn't look at the mesa sources, but are you sure this does the right
thing on uClibc w/locales? Normally you need to #include <features.h>
for the __UCLIBC_* defines - E.G.
./output/host/usr/bin/arm-linux-gcc -dM -E - < /dev/null |grep -c UCLIBC
0
echo '#include <features.h>' > dummy.c
./output/host/usr/bin/arm-linux-gcc -dM -E dummy.c |grep -c UCLIBC
76
--
Bye, Peter Korsgaard
next prev parent reply other threads:[~2011-10-05 18:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-19 20:57 [Buildroot] [pull request] Pull request for branch for-2011.11/x11r7-fixes Thomas Petazzoni
2011-09-19 20:57 ` [Buildroot] [PATCH 1/5] mesa: build statically because of DRI drivers Thomas Petazzoni
2011-09-20 6:43 ` Thomas Petazzoni
2011-10-05 17:12 ` Peter Korsgaard
2011-09-19 20:57 ` [Buildroot] [PATCH 2/5] x11r7: make package globally visible Thomas Petazzoni
2011-10-05 17:55 ` Peter Korsgaard
2011-09-19 20:57 ` [Buildroot] [PATCH 3/5] mesa3d: add patch to fix build on !locale toolchains Thomas Petazzoni
2011-10-05 18:02 ` Peter Korsgaard [this message]
2011-09-19 20:57 ` [Buildroot] [PATCH 4/5] xdata_xcursor-themes: add dependency on host xapp_xcursorgen Thomas Petazzoni
2011-10-05 18:21 ` Peter Korsgaard
2011-09-19 20:57 ` [Buildroot] [PATCH 5/5] x11r7: AUTORECONF=NO is the default, remove Thomas Petazzoni
2011-10-05 18:23 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8762k3pb8w.fsf@macbook.be.48ers.dk \
--to=jacmet@uclibc.org \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox