From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 3/3] disko-demos: new package
Date: Sun, 24 Jul 2011 22:39:40 +0200 [thread overview]
Message-ID: <8762mrwgz7.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <98bbd6aa00cc55c26b47e07333f98464df89bae0.1311138690.git.thomas.petazzoni@free-electrons.com> (Thomas Petazzoni's message of "Wed, 20 Jul 2011 07:11:54 +0200")
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:
Thomas> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Thanks, a few comments:
Thomas> --- /dev/null
Thomas> +++ b/package/multimedia/disko-demos/disko-demos-1.8.0-fix-install-paths.patch
Thomas> @@ -0,0 +1,61 @@
Thomas> +Allow proper configuration of /etc directory
Thomas> +
Thomas> +The disko-demos SConstruct build script forced to install
Thomas> +configuration files into <prefix>/etc, which means /usr/etc. This
Thomas> +patch adds a sysconfdir argument, which allows to specify a different
Thomas> +directory for configuration files.
Thomas> +
Thomas> +Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Has this been sent upstream?
Thomas> +++ b/package/multimedia/disko-demos/disko-demos.mk
Thomas> @@ -0,0 +1,27 @@
Thomas> +
Please drop this empty line.
Thomas> +DISKO_DEMOS_VERSION = 1.8.0
Thomas> +DISKO_DEMOS_SOURCE = disko-demos_$(DISKO_DEMOS_VERSION).tar.gz
Thomas> +DISKO_DEMOS_SITE = http://www.diskohq.com/repository/sources/
Thomas> +
Thomas> +DISKO_DEMOS_DEPENDENCIES = disko
Thomas> +
Thomas> +DISKO_DEMOS_SCONS_ENV = \
Thomas> + $(TARGET_CONFIGURE_OPTS)
No LD=$(TARGET_CC) like for disko?
--
Bye, Peter Korsgaard
next prev parent reply other threads:[~2011-07-24 20:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-20 5:11 [Buildroot] [pull request v2] Pull request for branch disko Thomas Petazzoni
2011-07-20 5:11 ` [Buildroot] [PATCH 1/3] scons: new package Thomas Petazzoni
2011-07-24 20:32 ` Peter Korsgaard
2011-07-20 5:11 ` [Buildroot] [PATCH 2/3] disko: " Thomas Petazzoni
2011-07-24 20:38 ` Peter Korsgaard
2011-07-20 5:11 ` [Buildroot] [PATCH 3/3] disko-demos: " Thomas Petazzoni
2011-07-24 20:39 ` Peter Korsgaard [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-07-20 4:43 [Buildroot] [pull request] Pull request for branch disko Thomas Petazzoni
2011-07-20 4:43 ` [Buildroot] [PATCH 3/3] disko-demos: new package Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8762mrwgz7.fsf@macbook.be.48ers.dk \
--to=jacmet@uclibc.org \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox