From: Peter Korsgaard <peter@korsgaard.com>
To: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Gleb Mazovetskiy <glex.spb@gmail.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] package/libmodplug: add a patch fixing cctype UB
Date: Fri, 13 Oct 2023 17:02:57 +0200 [thread overview]
Message-ID: <877cnq4lb2.fsf@48ers.dk> (raw)
In-Reply-To: <20231001194952.GO2579@scaer> (Yann E. MORIN's message of "Sun, 1 Oct 2023 21:49:52 +0200")
>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:
> Gleb, All,
> Sorry for the delay, now I've handled that patch...
> On 2023-01-09 22:00 +0000, Gleb Mazovetskiy spake thusly:
>> libmodplug calls `cctype` functions, such as `isspace`,
>> with negative values. This is undefined behaviour.
>>
>> While glibc allows it, it crashes on uClibc compiled
>> without `UCLIBC_HAS_CTYPE_SIGNED`.
>>
>> Adds a patch that resolves the issue.
> We discussed it during the hackathon this WE, and we were a bit ,eh
> about that patch, because it is a bit big, and upstream has not
> responded to it.
> However, upstream does indeed look pretty dead with no activity in the
> past two years and only the occasional commit before that, so there is
> very low risk at integrating this patch in Buildroot, as it should not
> cause much maintenance issue. On the off chance upstream ever release
> something new, we can assess the situation then.
>> Also sent upstream. However, the library author has not merged
>> any pull request for about a year.
>> https://github.com/Konstanty/libmodplug/pull/92
>>
>> Signed-off-by: Gleb Mazovetskiy <glex.spb@gmail.com>
> $ make check-package
> package/libmodplug/0001-fix-cctype-ub.patch:0: missing
> Signed-off-by in the header
> (http://nightly.buildroot.org/#_format_and_licensing_of_the_package_patches)
> package/libmodplug/0001-fix-cctype-ub.patch:0: missing Upstream in
> the header
> (http://nightly.buildroot.org/#_additional_patch_documentation)
> The latter is newer than your patch, so that's not your fault; I fixed
> it when applying.
> For the former, since your SoB-ed your Buildoot contribution, I
> copy-pasted it to the bundled patch too.
> Applied to master with that fixed, thanks.
> Eh, btw: I'm surprised people are still doing MOD nowadays! :-)
Committed to 2023.02.x and 2023.08.x, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2023-10-13 15:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-09 22:00 [Buildroot] [PATCH] package/libmodplug: add a patch fixing cctype UB Gleb Mazovetskiy
2023-10-01 19:49 ` Yann E. MORIN
2023-10-13 15:02 ` Peter Korsgaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877cnq4lb2.fsf@48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@buildroot.org \
--cc=glex.spb@gmail.com \
--cc=yann.morin.1998@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox