From: Peter Korsgaard <peter@korsgaard.com>
To: Julien Olivain <ju.o@free.fr>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/libjxl: fix riscv build
Date: Sun, 24 Sep 2023 20:38:20 +0200 [thread overview]
Message-ID: <877cofju1v.fsf@48ers.dk> (raw)
In-Reply-To: <20230915192308.1432032-1-ju.o@free.fr> (Julien Olivain's message of "Fri, 15 Sep 2023 21:23:07 +0200")
>>>>> "Julien" == Julien Olivain <ju.o@free.fr> writes:
> libjxl was failing to build for riscv targets, since commit ff7c37e57
> "package/libjxl: security bump to version 0.8.1". Build was failing with
> output:
> /build/libjxl-0.8.1/lib/jxl/enc_xyb.cc: In function 'jxl::Image3F jxl::N_SCALAR::TransformToLinearRGB(const jxl::Image3F&, const jxl::ColorEncoding&, float, const JxlCmsInterface&, jxl::ThreadPool*)':
> /build/libjxl-0.8.1/lib/jxl/enc_xyb.cc:223:21: error: variable 'std::atomic<bool> ok' has initializer but incomplete type
> 223 | std::atomic<bool> ok{true};
> | ^~
> This build failure was due to a missing <atomic> header inclusion. For
> some reason, the build failure was observed only with RISC-V toolchains.
> This commit fixes the issue by adding an upstream commit, not yet in a
> package release. See [1].
> Fixes:
> http://autobuild.buildroot.org/results/121/12107bc7aea7afae1d2fb935d31b44eee6ea1501
> [1] https://github.com/libjxl/libjxl/commit/22d12d74e7bc56b09cfb1973aa89ec8d714fa3fc
> Signed-off-by: Julien Olivain <ju.o@free.fr>
Committed to 2023.02.x, 2023.05.x and 2023.08.x, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2023-09-24 18:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-15 19:23 [Buildroot] [PATCH 1/1] package/libjxl: fix riscv build Julien Olivain
2023-09-15 21:09 ` Yann E. MORIN
2023-09-24 18:38 ` Peter Korsgaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877cofju1v.fsf@48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@buildroot.org \
--cc=ju.o@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox