From: Peter Korsgaard <peter@korsgaard.com>
To: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
Cc: Bartosz Bilas <b.bilas@grinn-global.com>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: Re: [Buildroot] [PATCH] gdb: disable source-highlight
Date: Tue, 12 Sep 2023 23:22:48 +0200 [thread overview]
Message-ID: <877cov5bo7.fsf@48ers.dk> (raw)
In-Reply-To: <20230812125051.4b8b0b84@windsurf> (Thomas Petazzoni via buildroot's message of "Sat, 12 Aug 2023 12:50:51 +0200")
>>>>> "Thomas" == Thomas Petazzoni via buildroot <buildroot@buildroot.org> writes:
> On Fri, 11 Aug 2023 11:34:21 +0200
> Bartosz Bilas <b.bilas@grinn-global.com> wrote:
>> It's being found from the host's source-highlight library
>> which results in the following build errors:
>>
>> ../../gdb/source-cache.c:37:10: fatal error: srchilite/sourcehighlight.h: No such file or directory
>> 37 | #include <srchilite/sourcehighlight.h>
>> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> compilation terminated.
>> make[4]: *** [Makefile:1645: source-cache.o] Error 1
>> make[4]: *** Waiting for unfinished jobs....
>>
>> Signed-off-by: Bartosz Bilas <b.bilas@grinn-global.com>
> Thanks patch applied to master, after updating the commit title to use
> "package/gdb: " as the prefix, to follow our convention.
> Also, I am wondering if the same should not be done for the host
> variant of gdb. Indeed, we don't want to rely on the system-provided
> source highlight if it's not built by Buildroot. Could you have a look
> into this, and if it makes sense, send a patch?
> Thanks a lot!
Committed to 2023.02.x and 2023.05.x, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2023-09-12 21:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-11 9:34 [Buildroot] [PATCH] gdb: disable source-highlight Bartosz Bilas
2023-08-12 10:50 ` Thomas Petazzoni via buildroot
[not found] ` <5cd4ca82-696e-037c-2a84-1de6f34cdc7f@grinn-global.com>
[not found] ` <20230817122702.18d7760f@windsurf>
2023-08-18 6:18 ` Bartosz Bilas
2023-09-12 21:22 ` Peter Korsgaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877cov5bo7.fsf@48ers.dk \
--to=peter@korsgaard.com \
--cc=b.bilas@grinn-global.com \
--cc=buildroot@buildroot.org \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox