From: Peter Korsgaard <peter@korsgaard.com>
To: "Raphaël Mélotte via buildroot" <buildroot@buildroot.org>
Cc: "Raphaël Mélotte" <raphael.melotte@mind.be>
Subject: Re: [Buildroot] [PATCH v2 1/1] package: busybox: backport fix for missing getrandom()
Date: Fri, 09 Jun 2023 11:10:10 +0200 [thread overview]
Message-ID: <877csd0znx.fsf@48ers.dk> (raw)
In-Reply-To: <20230509115831.634176-1-raphael.melotte@mind.be> ("Raphaël Mélotte via buildroot"'s message of "Tue, 9 May 2023 13:58:29 +0200")
>>>>> "Raphaël" == Raphaël Mélotte via buildroot <buildroot@buildroot.org> writes:
> The current Busybox version (1.36.0) fails to build with some
> libc/linux combinations where getrandom() is not available. Two fixes
> for glibc already exists upstream, so backport them here. A third
> one (submitted upstream, not part of the main branch yet) was needed
> to be able to compile with older musl and uClibc versions (or older
> kernels).
> This fixes the following build failure raised since commit
> d68b617993bd2f5c82a4936ed1e24e4fec6b94a2:
> miscutils/seedrng.c:45:24: fatal error: sys/random.h: No such file or directory
> #include <sys/random.h>
> Fixes:
> - http://autobuild.buildroot.net/results/44a0476b86c579e6aa658f156f0292958d40513c
> - http://autobuild.buildroot.net/results/ed028160db397581558fd8c96755621dd8298bb1
> - https://gitlab.com/buildroot.org/buildroot/-/jobs/4122624008
> - https://gitlab.com/buildroot.org/buildroot/-/jobs/4122624034
> - https://gitlab.com/buildroot.org/buildroot/-/jobs/4122624044
> - https://gitlab.com/buildroot.org/buildroot/-/jobs/4122624048
> - https://gitlab.com/buildroot.org/buildroot/-/jobs/4122624051
> It also fixes the following (similar) build failure, raised since the
> same commit:
> miscutils/lib.a(seedrng.o): In function `seedrng_main':
> seedrng.c:(.text.seedrng_main+0x26c): undefined reference to `getrandom'
> seedrng.c:(.text.seedrng_main+0x2e8): undefined reference to `getrandom'
> collect2: error: ld returned 1 exit status
> Fixes:
> - https://gitlab.com/buildroot.org/buildroot/-/jobs/4122624028
> - https://gitlab.com/buildroot.org/buildroot/-/jobs/4122624031
> Signed-off-by: Raphaël Mélotte <raphael.melotte@mind.be>
> ---
> Changes v1 -> v2:
> - fix building with make 4.2.1 and earlier.
> - use the current latest patch sent upstream (v4).
Committed to 2023.02.x, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2023-06-09 9:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-25 7:09 [Buildroot] [PATCH 1/1] package/mupdf: fix building with zlib-ng Raphaël Mélotte
2023-05-08 21:02 ` Yann E. MORIN
2023-05-09 11:58 ` [Buildroot] [PATCH v2 1/1] package: busybox: backport fix for missing getrandom() Raphaël Mélotte via buildroot
2023-05-09 18:50 ` Yann E. MORIN
2023-06-09 9:10 ` Peter Korsgaard [this message]
2023-06-09 8:11 ` [Buildroot] [PATCH 1/1] package/mupdf: fix building with zlib-ng Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877csd0znx.fsf@48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@buildroot.org \
--cc=raphael.melotte@mind.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox