From: Peter Korsgaard <peter@korsgaard.com>
To: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Kory Maincent <kory.maincent@bootlin.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] package/edk2-platforms: fix installation
Date: Thu, 21 Oct 2021 16:32:23 +0200 [thread overview]
Message-ID: <877de678js.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20211004201737.1976547-1-yann.morin.1998@free.fr> (Yann E. MORIN's message of "Mon, 4 Oct 2021 22:17:37 +0200")
>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:
> There are currently three issues with the installation step:
> 1. it does not ensure the parent destination directory exists before
> copying into it, so if /usr/share has not been created in the
> dependency chain of edk2-platforms, the installation fails, which
> may very well happen easily as edk2-plaforms has nothing in its
> dependency chain (except the toolchain et al.);
> 2. all our dot-stampfiles and .files-list are also copied, as well as
> the Readme, license files, and maintainers file. All of those are
> useless on the target (and the .files-list introduce
> non-reproduciiblity);
> 3. of a lesser importance, the construct to install, and specifically
> to reinstall, does not match what we usually do in Buildroot
> (removal of the directory to copy).
> We fix all three in one fell swoop:
> 1. create the destination directory if needed;
> 2. copy just the directories with the actual platform descriptions
> Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
> Cc: Dick Olsson <hi@senzilla.io>
> Cc: Kory Maincent <kory.maincent@bootlin.com>
Committed to 2021.08.x, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2021-10-21 14:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-04 20:17 [Buildroot] [PATCH] package/edk2-platforms: fix installation Yann E. MORIN
2021-10-15 20:03 ` Arnout Vandecappelle
2021-10-21 14:32 ` Peter Korsgaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877de678js.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@buildroot.org \
--cc=kory.maincent@bootlin.com \
--cc=yann.morin.1998@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox