public inbox for buildroot@busybox.net
 help / color / mirror / Atom feed
From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/collectd: make network crypto support discoverable
Date: Tue, 07 Apr 2020 18:06:19 +0200	[thread overview]
Message-ID: <877dyrqo04.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20200311133504.13911-1-p.debruijn@unilogic.nl> (Pascal de Bruijn's message of "Wed, 11 Mar 2020 14:35:04 +0100")

>>>>> "Pascal" == Pascal de Bruijn <p.debruijn@unilogic.nl> writes:

 > before it was completely non-obvious how to get crypto support
 > in collectd's network module

 > this introduces a collectd config option which makes sure
 > gcrypt is built, and can't be accidentally unselected
 > resulting in an accidental non-crypto build of collectd

 > Signed-off-by: Pascal de Bruijn <p.debruijn@unilogic.nl>
 > ---
 >  package/collectd/Config.in | 7 +++++++
 >  1 file changed, 7 insertions(+)

 > diff --git a/package/collectd/Config.in b/package/collectd/Config.in
 > index 303b5dc01b..4b34ec60eb 100644
 > --- a/package/collectd/Config.in
 > +++ b/package/collectd/Config.in
 > @@ -603,6 +603,13 @@ config BR2_PACKAGE_COLLECTD_NETWORK
 >  	help
 >  	  Send/receive values from other instances of collectd.
 
 > +config BR2_PACKAGE_COLLECTD_NETWORK_GCRYPT
 > +	bool "crypto support"
 > +	depends on BR2_PACKAGE_COLLECTD_NETWORK
 > +	select BR2_PACKAGE_LIBGCRYPT
 > +	help
 > +	  Enable crypto support

It would IMHO also make sense to change the conditional in collectd.mk
to use this symbol so crypto support is really disabled if this option
is turned off, otherwise it is just confusing in the other direction
now.

-- 
Bye, Peter Korsgaard

  parent reply	other threads:[~2020-04-07 16:06 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-11 13:35 [Buildroot] [PATCH] package/collectd: make network crypto support discoverable Pascal de Bruijn
2020-03-22 15:07 ` Thomas Petazzoni
2020-04-07 16:06 ` Peter Korsgaard [this message]
2020-04-21 20:54   ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877dyrqo04.fsf@dell.be.48ers.dk \
    --to=peter@korsgaard.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox