Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCHv2] docs/manual: using a branch name as FOO_VERSION does not work
Date: Mon, 28 May 2018 16:22:15 +0200	[thread overview]
Message-ID: <877ennzwq0.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20180511155058.26875-1-yann.morin.1998@free.fr> (Yann E. MORIN's message of "Fri, 11 May 2018 17:50:58 +0200")

>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:

 > For various reasons, we've always suggested users to avoid using a
 > branch as version string for their packages, because it does not work
 > as a they would expect:

 >   - it is not reproducible, because the branch may change between two
 >     builds that are done at different times;

 >   - it does not even follow the branch, as Buildroot anyway generates
 >     a local tarball, which it will reuse on subsequent builds.
 >     Furthermore, since we fetch and not pull, any existing local branch
 >     is not updated.

 > Yet, until recently, using a branch name would just work (with the
 > above limitations): the git tree was cloned, the branch checked out,
 > and the tarball created.

 > But with the advent of the git caching, using a branch name does not
 > work anymore. Indeed, we now do a git-fetch, and that does not create
 > local master branch. So we can't check out master, because it does not
 > exist locally. And for other branches, as noticed above, the local
 > branch does not get udpated to the remote one.

 > Furthermore, the local branches are only created by chance, again as a
 > side-effect of trying to fetch the "special refs".

 > So, we can't say that we reliably support the use of a branch name.

 > Update the manual to state that using a branch does not work. Remove
 > the 'stable' example, as it looked like the name of a stable branch;
 > instead, replace it with a version string that ressemble a tag.

 > Fix the layout of the manual by making the version examples an actual
 > bulleted list.

 > Note: the above is only entirely true for git. For Mercurial, CVS and
 > subversion, the status may be mixed, but nonetheless, using branches is
 > still a bad idea, if at least because it is not reproducible, and
 > because Buildroot does not even follow the branch. So, we do not
 > differentiate between the various SCMs, and just flatly state that using
 > a branch name is not supported.

 > Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
 > Cc: Thomas De Schampheleire <patrickdepinguin@gmail.com>
 > Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
 > Cc: Maxime Hadjinlian <maxime.hadjinlian@gmail.com>
 > Cc: Peter Korsgaard <peter@korsgaard.com>

 > ---
 > Changes v1 -> v2:
 >   - enhance commit log with additional details  (Ricardo)
 >   - blurb about
 >   - typoes in commit log  (Ricardo)

Committed to 2018.02.x, thanks. While we do not have the reworked
download support (and hence the issue that triggered this), we should
still not recommend people to use branch names as versions.

-- 
Bye, Peter Korsgaard

      parent reply	other threads:[~2018-05-28 14:22 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-11 15:50 [Buildroot] [PATCHv2] docs/manual: using a branch name as FOO_VERSION does not work Yann E. MORIN
2018-05-11 19:38 ` Thomas De Schampheleire
2018-05-11 21:05 ` Thomas Petazzoni
2018-05-28 14:22 ` Peter Korsgaard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877ennzwq0.fsf@dell.be.48ers.dk \
    --to=peter@korsgaard.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox