Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2,1/1] domoticz: depends on NPTL
Date: Tue, 27 Feb 2018 21:35:13 +0100	[thread overview]
Message-ID: <877eqynpby.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20180210195815.20942-1-fontaine.fabrice@gmail.com> (Fabrice Fontaine's message of "Sat, 10 Feb 2018 20:58:15 +0100")

>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:

 > boost 1.66 uses pthread_condattr_setclock in
 > boost/asio/detail/impl/posix_event.ipp.

 > Boost is mostly a header-only library, in particular the asio stuff.
 > There are sub-options for the parts of Boost that are not purely
 > headers, but there are not any sub-options for the parts of Boost that
 > are just headers.

 > So, the options are either to add sub-options to Boost, or to make
 > Boost as a whole only available on NPTL toolchains. The latter is a bit
 > annoying as it would mean adding this dependency to all Boost reverse
 > dependencies, even those not using asio.

 > So, instead of updating boost, add a dependency to
 > BR2_TOOLCHAIN_HAS_THREADS_NPTL to domoticz. This is the best solution
 > that can be done today. It's not perfect, but it's good enough.

 > Fixes:
 >  - http://autobuild.buildroot.net/results/197baa15cbf7f4fc7b3ccc602515af3f375ed68f

 > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
 > ---
 > Changes v1 -> v2 (after review of Peter Korsgaard and Thomas Petazzoni):
 >  - Add Thomas's explanation/opinion in commit message

Committed, thanks.

-- 
Bye, Peter Korsgaard

      reply	other threads:[~2018-02-27 20:35 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-10 19:58 [Buildroot] [PATCH v2,1/1] domoticz: depends on NPTL Fabrice Fontaine
2018-02-27 20:35 ` Peter Korsgaard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877eqynpby.fsf@dell.be.48ers.dk \
    --to=peter@korsgaard.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox