From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] dhcpcd: add SysV start-up script
Date: Fri, 03 Nov 2017 16:59:09 +0100 [thread overview]
Message-ID: <877ev75p6a.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20171102230602.3c61e8d2@windsurf> (Thomas Petazzoni's message of "Thu, 2 Nov 2017 23:06:02 +0100")
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:
Hi,
>> +[ -x $DAEMON ] || exit 0
>> +[ -f $CONFIG ] || exit 0
> We have these in a lot of init scripts, so I kept them. But I find
> those tests pretty silly in fact:
> - The daemon should definitely be there, as it's installed by the same
> package. And if it turns out not to be there, I'd prefer a loud
> failure than an init script that silently ignores the problem.
> - Same for the configuration file: I prefer a loud error than an init
> script that ignores the problem.
> Yann, Peter, Arnout, can we agree that such tests should be removed
> entirely, and we let the init script fail if the daemon does not exist,
> and the daemon fail if its configuration file does not exist ?
Sounds sensible to me.
--
Bye, Peter Korsgaard
next prev parent reply other threads:[~2017-11-03 15:59 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-31 22:36 [Buildroot] [PATCH 0/2] dhcpcd: start-up scripts Markus Mayer
2017-10-31 22:36 ` [Buildroot] [PATCH 1/2] dhcpcd: add SysV start-up script Markus Mayer
2017-11-02 22:06 ` Thomas Petazzoni
2017-11-02 22:18 ` Yann E. MORIN
2017-11-02 22:23 ` Thomas Petazzoni
2017-11-03 16:10 ` Yann E. MORIN
2017-11-03 16:17 ` Thomas Petazzoni
2017-11-03 16:31 ` Yann E. MORIN
2017-11-04 19:56 ` Arnout Vandecappelle
2017-11-04 22:03 ` Thomas Petazzoni
2017-11-04 22:07 ` Arnout Vandecappelle
2017-11-04 22:22 ` Thomas Petazzoni
2017-11-05 8:16 ` Yann E. MORIN
2017-11-05 8:10 ` Yann E. MORIN
2017-11-05 12:18 ` Arnout Vandecappelle
2017-11-05 13:24 ` Thomas Petazzoni
2017-11-05 13:28 ` Yann E. MORIN
2017-11-03 15:59 ` Peter Korsgaard [this message]
2017-10-31 22:36 ` [Buildroot] [PATCH 2/2] dhcpcd: add systemd start-up service Markus Mayer
2017-11-02 22:06 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877ev75p6a.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox