Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/transmission: fix gtk support
Date: Sat, 02 Sep 2017 01:17:26 +0200	[thread overview]
Message-ID: <877exiqa9l.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20170710175137.1402-1-bernd.kuhls@t-online.de> (Bernd Kuhls's message of "Mon, 10 Jul 2017 19:51:37 +0200")

>>>>> "Bernd" == Bernd Kuhls <bernd.kuhls@t-online.de> writes:

 > Gtk support is controlled by ARG_WITH since
 > https://github.com/transmission/transmission/commit/2ccc2bbbfe2e4a26dfeaa13b56c412ea0af4ebe4

 > Fixes a build error if libgtk2/3 was built before transmission:
 > http://autobuild.buildroot.net/results/6b6/6b6ce352a9edfe3aaba82be143092a878e7715ed/

 > Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
 > ---
 >  package/transmission/transmission.mk | 4 ++--
 >  1 file changed, 2 insertions(+), 2 deletions(-)

 > diff --git a/package/transmission/transmission.mk b/package/transmission/transmission.mk
 > index f8abb2b8b..d84e5cb77 100644
 > --- a/package/transmission/transmission.mk
 > +++ b/package/transmission/transmission.mk
 > @@ -82,10 +82,10 @@ TRANSMISSION_CONF_OPTS += --disable-remote
 >  endif
 
 >  ifeq ($(BR2_PACKAGE_TRANSMISSION_GTK),y)
 > -TRANSMISSION_CONF_OPTS += --enable-gtk
 > +TRANSMISSION_CONF_OPTS += --with-gtk
 >  TRANSMISSION_DEPENDENCIES += libgtk2

Committed, thanks. I also pushed two followup patches to actually get it
to build:

- transmission-gtk needs libgtk3 instead of libgtk2 since 2.61
  (E.G. your version bump in 2013)

- Adjusted NLS dependencies after the recent NLS rework
  (BR2_SYSTEM_ENABLE_NLS).

-- 
Bye, Peter Korsgaard

      parent reply	other threads:[~2017-09-01 23:17 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-10 17:51 [Buildroot] [PATCH 1/1] package/transmission: fix gtk support Bernd Kuhls
2017-07-11 19:37 ` Peter Korsgaard
2017-07-11 21:17   ` Thomas Petazzoni
2017-07-11 21:42     ` Arnout Vandecappelle
2017-07-11 21:57       ` Peter Korsgaard
2017-07-12  7:49       ` Thomas Petazzoni
2017-07-12  9:03         ` Thomas Petazzoni
2017-07-12 10:04         ` Arnout Vandecappelle
2017-09-01 23:18           ` Peter Korsgaard
2017-09-01 23:17 ` Peter Korsgaard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877exiqa9l.fsf@dell.be.48ers.dk \
    --to=peter@korsgaard.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox