From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Korsgaard Date: Wed, 02 Jul 2014 23:42:41 +0200 Subject: [Buildroot] [PATCH 03/14] pkg-infra: move the git download helper to a script In-Reply-To: <20140702203748.GC9383@free.fr> (Yann E. MORIN's message of "Wed, 2 Jul 2014 22:37:48 +0200") References: <87fvijbx17.fsf@dell.be.48ers.dk> <20140702174430.3f1377ce@free-electrons.com> <20140702192243.20920b70@free-electrons.com> <20140702223122.72ccaf58@free-electrons.com> <20140702203748.GC9383@free.fr> Message-ID: <877g3vbfou.fsf@dell.be.48ers.dk> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net >>>>> "Yann" == Yann E MORIN writes: Hi, >> I think what Peter complains about is that with just PATCH 03/14 >> applied, the Git download method no longer works properly as it leaves >> the repo in $(DL_DIR). Indeed. >> The fact that this problem may or may not get solved by a later patch >> in the series is more-or-less irrelevant here: > Agreed. If that patch changes the behaviour, it is incorrect. >> Peter is just saying >> that the series is not perfectly bisectable, and he stopped reviewing >> when he saw an issue in PATCH 03/14. > And I do not see this issue... Sorry, I got confused. The problem actually turned out to be the use of pushd/popd with a /bin/sh, on here /bin/sh is dash which doesn't support it. The fix is to use !#/bin/bash -- Bye, Peter Korsgaard