From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/tvheadend: Add optional dependency to libiconv
Date: Wed, 11 Jun 2014 14:45:27 +0200 [thread overview]
Message-ID: <877g4nipi0.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <XnsA34990F24E603berndkuhlsPkbjNfxxIA@bernd-kuhls.de> (Bernd Kuhls's message of "Wed, 11 Jun 2014 14:14:55 +0200")
>>>>> "Bernd" == Bernd Kuhls <bernd.kuhls@t-online.de> writes:
> Thomas Petazzoni <thomas.petazzoni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8
> @public.gmane.org> wrote in news:20140609195850.2317401f at free-electrons.com:
>> You need libiconv because your toolchain does not have locale support.
>> Therefore, your Config.in should have something like:
>>
>> select BR2_PACKAGE_LIBICONV if !BR2_ENABLE_LOCALE
>>
>> see all the other examples in Buildroot.
> Hi,
> libiconv is not a hard-dependency of tvheadend so I thought enabling libiconv
> in the !BR2_ENABLE_LOCALE case is not necessary here.
Ahh, so it's just an optional dependency it CAN use if available? Then
the patch is fine.
Somehow I don't see it anymore in patchwork though?
--
Bye, Peter Korsgaard
next prev parent reply other threads:[~2014-06-11 12:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-09 11:23 [Buildroot] [PATCH 1/1] package/tvheadend: Add optional dependency to libiconv Bernd Kuhls
2014-06-09 14:04 ` Yann E. MORIN
2014-06-09 17:58 ` Thomas Petazzoni
2014-06-11 12:14 ` Bernd Kuhls
2014-06-11 12:45 ` Peter Korsgaard [this message]
2014-06-11 13:03 ` Bernd Kuhls
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877g4nipi0.fsf@dell.be.48ers.dk \
--to=jacmet@uclibc.org \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox