Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] vala: do not append a -dirty suffix to the valac version number
Date: Fri, 18 May 2012 16:57:44 +0200	[thread overview]
Message-ID: <877gw9o7tj.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <CAHt8ZCNqGagUPjq4ZvfRBKogfbVfKJnRH7mR6rpL7LPYdvdtuQ@mail.gmail.com> (Simon Dawson's message of "Fri, 18 May 2012 14:06:54 +0100")

>>>>> "Simon" == Simon Dawson <spdawson@gmail.com> writes:

Hi,

 Simon> In essence, I think the patch is necessary in order to prevent the
 Simon> valac build process from falling foul of uncommitted changes in the
 Simon> local Buildroot checkout. Of course, if you've got uncommitted changes
 Simon> in the repository in which you're testing, then my theory goes out of
 Simon> the window...

Ahh, ok. That was not clear to me from your commit message. We have
something similar for autoconf
(autoconf-2.65-dont-add-dirty-to-version.patch). Care to adjust patch
description and commit message and resend?

-- 
Bye, Peter Korsgaard

  reply	other threads:[~2012-05-18 14:57 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-16 12:10 [Buildroot] [PATCH 1/2] vala: do not append a -dirty suffix to the valac version number spdawson at gmail.com
2012-05-16 12:10 ` [Buildroot] [PATCH 2/2] midori: bump version to 0.4.6 spdawson at gmail.com
2012-05-18  8:44 ` [Buildroot] [PATCH 1/2] vala: do not append a -dirty suffix to the valac version number Peter Korsgaard
2012-05-18 13:06   ` Simon Dawson
2012-05-18 14:57     ` Peter Korsgaard [this message]
  -- strict thread matches above, loose matches on Subject: below --
2012-05-18 16:15 spdawson at gmail.com
2012-05-18 16:47 ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877gw9o7tj.fsf@macbook.be.48ers.dk \
    --to=jacmet@uclibc.org \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox