From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 3/4] ffmpeg: allow customization of codecs, (de)muxers and other components
Date: Mon, 14 Jun 2010 11:26:53 +0200 [thread overview]
Message-ID: <877hm2ezhe.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <L3ZXW6$DC1420A5D64F3A5EE742F2128E2CC026@aruba.it> (Luca Ceresoli's message of "Mon, 14 Jun 2010 10:50:30 +0200")
>>>>> "Luca" == Luca Ceresoli <luca@lucaceresoli.net> writes:
Hi,
Luca> +ifneq ($(BR2_PACKAGE_FFMPEG_DECODERS),"all")
>>
>> I would suggest you use qstrip + strip here as well, so it doesn't break if the
>> user accidently added extra spaces or so.
Luca> How can foreach break with extra spaces? I've been trying things as:
>> BR2_PACKAGE_FFMPEG_ENCODERS=" vorbis flac "
Luca> and they work ok.
Not the foreach, but the ifneq (....,"all") would break if the user
ended up setting it to "all " or " all" or similar.
--
Bye, Peter Korsgaard
next prev parent reply other threads:[~2010-06-14 9:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-14 8:50 [Buildroot] [PATCH 3/4] ffmpeg: allow customization of codecs, (de)muxers and other components Luca Ceresoli
2010-06-14 9:26 ` Peter Korsgaard [this message]
-- strict thread matches above, loose matches on Subject: below --
2010-06-14 10:00 Luca Ceresoli
2010-06-14 11:25 ` Peter Korsgaard
2010-06-12 16:22 [Buildroot] Add ffmpeg support Luca Ceresoli
2010-06-12 16:22 ` [Buildroot] [PATCH 3/4] ffmpeg: allow customization of codecs, (de)muxers and other components Luca Ceresoli
2010-06-13 12:01 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877hm2ezhe.fsf@macbook.be.48ers.dk \
--to=jacmet@uclibc.org \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox