Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 15/16] ace_of_penguins: mark as BROKEN
Date: Mon, 22 Feb 2010 16:54:40 +0100	[thread overview]
Message-ID: <877hq5jmf3.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <bf37d2e1dfc2249239e95c5a83fbcad4441e6670.1266691382.git.thomas.petazzoni@free-electrons.com> (Thomas Petazzoni's message of "Sat, 20 Feb 2010 19:43:06 +0100")

>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:

 Thomas> This package is BROKEN in the way it compiles make-imglib and text2c
 Thomas> for the host while being in cross-compiled mode. It does not use
 Thomas> CC_FOR_BUILD and CFLAGS_FOR_BUILD as it should.

 Thomas> No upstream release has been made since 2001 and since it is a
 Thomas> relatively useless package, I don't think it's worth the trouble to
 Thomas> sanitize its build system.

I agree.

 Thomas> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
 Thomas> ---
 Thomas>  package/games/ace_of_penguins/Config.in |    1 +
 Thomas>  1 files changed, 1 insertions(+), 0 deletions(-)

 Thomas> diff --git a/package/games/ace_of_penguins/Config.in b/package/games/ace_of_penguins/Config.in
 Thomas> index 1d5a367..2240e7c 100644
 Thomas> --- a/package/games/ace_of_penguins/Config.in
 Thomas> +++ b/package/games/ace_of_penguins/Config.in
 Thomas> @@ -3,6 +3,7 @@ config BR2_PACKAGE_ACE_OF_PENGUINS
 Thomas>  	select BR2_PACKAGE_LIBPNG
 Thomas>  	depends on BR2_PACKAGE_XORG7
 Thomas>  	depends on BR2_PACKAGE_XLIB_LIBXPM
 Thomas> +	depends on BROKEN

It's nice to add a short # comment about why it's broken, like:

games/vice/Config.in:   depends on BROKEN # doesn't build, wrong dependencie

-- 
Bye, Peter Korsgaard

  reply	other threads:[~2010-02-22 15:54 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-20 18:42 [Buildroot] [pull request] Pull request for branch misc-fixes5 Thomas Petazzoni
2010-02-20 18:42 ` [Buildroot] [PATCH 01/16] automake: add build dependency on host-autoconf Thomas Petazzoni
2010-02-22 15:51   ` Peter Korsgaard
2010-02-20 18:42 ` [Buildroot] [PATCH 02/16] ccache: remove cleanup of documentation Thomas Petazzoni
2010-02-20 18:42 ` [Buildroot] [PATCH 03/16] libxml2: do not apply libtool patch when compiling for host Thomas Petazzoni
2010-02-22 15:47   ` Peter Korsgaard
2010-02-22 19:11     ` Thomas Petazzoni
2010-02-20 18:42 ` [Buildroot] [PATCH 04/16] libxslt: enable compilation on host Thomas Petazzoni
2010-02-20 18:42 ` [Buildroot] [PATCH 05/16] libxcb: fix build with Buildroot compiled xsltproc Thomas Petazzoni
2010-02-20 18:42 ` [Buildroot] [PATCH 06/16] xapp_mkfontscale: enable compilation for the host Thomas Petazzoni
2010-02-22 15:52   ` Peter Korsgaard
2010-02-22 19:20     ` Thomas Petazzoni
2010-02-20 18:42 ` [Buildroot] [PATCH 07/16] xfont_encoding: add mkfontscale on the host as dependency Thomas Petazzoni
2010-02-20 18:42 ` [Buildroot] [PATCH 08/16] xlib_libfontenc: enable compilation on the host Thomas Petazzoni
2010-02-20 18:43 ` [Buildroot] [PATCH 09/16] zlib: " Thomas Petazzoni
2010-02-22 15:56   ` Peter Korsgaard
2010-02-20 18:43 ` [Buildroot] [PATCH 10/16] xfont_font-util: convert to the autotools infrastructure Thomas Petazzoni
2010-02-22 15:56   ` Peter Korsgaard
2010-02-20 18:43 ` [Buildroot] [PATCH 11/16] package infrastructure: add LD_LIBRARY_PATH Thomas Petazzoni
2010-02-21 21:30   ` Lionel Landwerlin
2010-02-22 15:59   ` Peter Korsgaard
2010-02-22 19:21     ` Thomas Petazzoni
2010-02-20 18:43 ` [Buildroot] [PATCH 12/16] libpng: enable compilation on the host Thomas Petazzoni
2010-02-21 21:31   ` Lionel Landwerlin
2010-02-22 16:00   ` Peter Korsgaard
2010-02-22 19:21     ` Thomas Petazzoni
2010-02-20 18:43 ` [Buildroot] [PATCH 13/16] ace_of_penguins: add dependency on host-libpng Thomas Petazzoni
2010-02-20 18:43 ` [Buildroot] [PATCH 14/16] merge with libpng for host Thomas Petazzoni
2010-02-20 18:43 ` [Buildroot] [PATCH 15/16] ace_of_penguins: mark as BROKEN Thomas Petazzoni
2010-02-22 15:54   ` Peter Korsgaard [this message]
2010-02-20 18:43 ` [Buildroot] [PATCH 16/16] dependencies: add gzip and bzip2 as base dependencies Thomas Petazzoni
2010-02-21 17:47 ` [Buildroot] [pull request] Pull request for branch misc-fixes5 Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877hq5jmf3.fsf@macbook.be.48ers.dk \
    --to=jacmet@uclibc.org \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox