From: Peter Korsgaard <peter@korsgaard.com>
To: Julien Olivain <ju.o@free.fr>
Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] boot/grub2: replace host-python3 with BR2_PYTHON3_HOST_DEPENDENCY
Date: Thu, 03 Oct 2024 11:32:36 +0200 [thread overview]
Message-ID: <878qv5o7kb.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20240929165343.1570582-1-ju.o@free.fr> (Julien Olivain's message of "Sun, 29 Sep 2024 18:53:43 +0200")
>>>>> "Julien" == Julien Olivain <ju.o@free.fr> writes:
> Commit 86bb1b236 "boot/grub2: needs host-python3" [1] introduced a
> dependency on host-python3.
> Since grub does not have any specific requirements on host Python
> modules, or recent host Python version, this commit replaces the
> host-python3 dependency with BR2_PYTHON3_HOST_DEPENDENCY. This will
> skip the host-python3 compilation if a sufficient version (3.4 or
> greater at the time of this commit) is already present on host. This
> will save build time.
> This optimization was suggested by Peter, in [2].
> Note 1: this commit was checked to ensure that grub is building with
> Python 3.4.
> Note 2: BR2_PYTHON3_HOST_DEPENDENCY was introduced in commit b60729784
> "support/dependencies: add a check for python3" [3].
> [1] https://gitlab.com/buildroot.org/buildroot/-/commit/86bb1b2360bdaed069cd087541f4edad1d5ce925
> [2] https://lists.buildroot.org/pipermail/buildroot/2024-September/763967.html
> [3] https://gitlab.com/buildroot.org/buildroot/-/commit/b60729784ab1c2f75dca30f924f4dd3176713ae8
> Signed-off-by: Julien Olivain <ju.o@free.fr>
Committed, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2024-10-03 9:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-29 16:53 [Buildroot] [PATCH 1/1] boot/grub2: replace host-python3 with BR2_PYTHON3_HOST_DEPENDENCY Julien Olivain
2024-10-03 9:32 ` Peter Korsgaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878qv5o7kb.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@buildroot.org \
--cc=ju.o@free.fr \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox