Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <peter@korsgaard.com>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/squid: needs gcc and host gcc >= 8
Date: Thu, 21 Mar 2024 21:11:42 +0100	[thread overview]
Message-ID: <878r2b8hvl.fsf@48ers.dk> (raw)
In-Reply-To: <20240306121823.610202-1-fontaine.fabrice@gmail.com> (Fabrice Fontaine's message of "Wed, 6 Mar 2024 13:18:23 +0100")

>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:

 > cf_gen.cc is compiled by host compiler and unconditionally uses auto
 > since bump to version 6.6 in commit
 > c13199c9326fa2daa574f08ec8fc063a48d0eb06 and
 > https://github.com/squid-cache/squid/commit/09835feb258c3058d028918e36d959dccb3f7496
 > resulting in the following build failure with host gcc < 8:

 > /usr/bin/g++ -O2 -I/home/buildroot/autobuild/run/instance-1/output-1/host/include -o cf_gen ./cf_gen.cc -I. -I../include/ -I../src
 > ./cf_gen.cc: In function 'int main(int, char**)':
 > ./cf_gen.cc:268:63: error: forming reference to void
 >                      auto &newEntry = entries.emplace_back(name);
 >                                                                ^

 > So add a dependency on host gcc >= 8 and gcc >= 8 as advocated by
 > upstream in
 > https://github.com/squid-cache/squid/blob/9d3433c4ac6cd547c10cf298b8a5e61a463fb753/doc/release-notes/release-6.sgml.in:

 >   This release adds a dependency on C++17 support in any compiler used to build Squid.
 >   GCC 8+ and Clang 8+ support C++17.

 > While at it, drop BR2_TOOLCHAIN_HAS_GCC_BUG_64735 which is always false
 > with gcc >= 7

 > Fixes: c13199c9326fa2daa574f08ec8fc063a48d0eb06
 >  - http://autobuild.buildroot.org/results/f1766d1a3b2ce7745fa23cdeae1101806cd97aea

 > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>


Committed to 2024.02.x, 2023.02.x and 2023.11.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

      parent reply	other threads:[~2024-03-21 20:11 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-06 12:18 [Buildroot] [PATCH 1/1] package/squid: needs gcc and host gcc >= 8 Fabrice Fontaine
2024-03-07 11:21 ` Peter Korsgaard
2024-03-21 20:11 ` Peter Korsgaard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878r2b8hvl.fsf@48ers.dk \
    --to=peter@korsgaard.com \
    --cc=buildroot@buildroot.org \
    --cc=fontaine.fabrice@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox