From: Peter Korsgaard <peter@korsgaard.com>
To: Adam Duskett <adam.duskett@amarulasolutions.com>
Cc: Angelo Compagnucci <angelo.compagnucci@gmail.com>,
"Yann E. MORIN" <yann.morin.1998@free.fr>,
buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 0/3] Add tainting support
Date: Wed, 08 Nov 2023 21:27:39 +0100 [thread overview]
Message-ID: <878r78q9c4.fsf@48ers.dk> (raw)
In-Reply-To: <CAHDQB6OVYYoG+y7JjcUFs5js_Kqe48z69BskS8MOCV62kpc4LQ@mail.gmail.com> (Adam Duskett's message of "Sun, 5 Nov 2023 10:07:17 -0700")
>>>>> "Adam" == Adam Duskett <adam.duskett@amarulasolutions.com> writes:
> Yes, but to your original points
> https://patchwork.ozlabs.org/project/buildroot/list/?series=64340, this is
> not
> an acceptable solution to put "NODEJS_SRC_LICENSE += , vendored
> dependencies licenses probably not listed"
> in the makefile, because there are several valid instances where you may be
> able to guarantee the integrity of
> the licenses and provide hashsums for each of them. Hence, the ability to
> disable the taint check.
In that case you would probably make individual packages for those to
have the download/license/hash stuff integrated?
As is this seems very vague and not something that will be tested by the
autobuilders, so I prefer Yann's simple npm license addition.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2023-11-08 20:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-03 18:27 [Buildroot] [PATCH 0/3] Add tainting support Adam Duskett
2023-11-03 18:27 ` [Buildroot] [PATCH 1/3] Makefile: add " Adam Duskett
2023-11-03 18:27 ` [Buildroot] [PATCH 2/3] docs/manual: add information about tainting Adam Duskett
2023-11-03 18:27 ` [Buildroot] [PATCH 3/3] package/nodejs: taint the build when using external modules Adam Duskett
2023-11-03 21:31 ` [Buildroot] [PATCH 0/3] Add tainting support Yann E. MORIN
2023-11-05 17:07 ` Adam Duskett
2023-11-08 20:27 ` Peter Korsgaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878r78q9c4.fsf@48ers.dk \
--to=peter@korsgaard.com \
--cc=adam.duskett@amarulasolutions.com \
--cc=angelo.compagnucci@gmail.com \
--cc=buildroot@buildroot.org \
--cc=yann.morin.1998@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox