Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Joachim Wiberg <troglobit@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/libteam: new package
Date: Wed, 14 Jul 2021 09:05:36 +0200	[thread overview]
Message-ID: <878s29wf27.fsf@gmail.com> (raw)
In-Reply-To: <CAGm1_ksZH1EFy=kzgy2pMtCfec-6dwuOZnkVtbwb5bJxzkCOVA@mail.gmail.com>


Hi Yegor!

On Tue, Jul 13, 2021 at 06:43, Yegor Yefremov <yegorslists@googlemail.com> wrote:
> On Sat, Jul 10, 2021 at 1:42 PM Joachim Wiberg <troglobit@gmail.com> wrote:
>> [snip]
>> +++ b/package/libteam/Config.in
>> @@ -0,0 +1,20 @@
>> +config BR2_PACKAGE_LIBTEAM
>> +       bool "libteam"
>> +       depends on BR2_USE_MMU # fork()
>> +       select BR2_PACKAGE_JANSSON
>> +       select BR2_PACKAGE_LIBDAEMON
>> +       select BR2_PACKAGE_LIBNL
>> +       select BR2_PACKAGE_LIBNL_TOOLS
>> +       help
>> [snip]
>
> The dependencies for libnl and tools are missing:
>
> comment "libnl tools needs a toolchain w/ dynamic library"
>         depends on BR2_STATIC_LIBS
>
> comment "libnl needs a toolchain w/ threads"
>         depends on !BR2_TOOLCHAIN_HAS_THREADS
>

Aha, I didn't realize I needed to unwind and list all the deps from my
package's dependencies as well.  But only in the Config.in, right?

I'll post a v2 later this week.

Thanks
 /Joachim

  reply	other threads:[~2021-07-14  7:05 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-10 11:41 [Buildroot] [PATCH 0/1] Add support for teamd/libteam Joachim Wiberg
2021-07-10 11:41 ` [Buildroot] [PATCH 1/1] package/libteam: new package Joachim Wiberg
2021-07-13  4:43   ` Yegor Yefremov
2021-07-14  7:05     ` Joachim Wiberg [this message]
2021-07-14  7:41       ` Yegor Yefremov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878s29wf27.fsf@gmail.com \
    --to=troglobit@gmail.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox