From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v7 1/1] package/nodejs: use system-icu for host-nodejs
Date: Thu, 13 Aug 2020 18:44:23 +0200 [thread overview]
Message-ID: <878sei7axk.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20200727115155.824789-1-james.hilliard1@gmail.com> (James Hilliard's message of "Mon, 27 Jul 2020 05:51:55 -0600")
>>>>> "James" == James Hilliard <james.hilliard1@gmail.com> writes:
> The nodejs configure.py file orders zlib headers before the bundled ICU
> headers. The zlib headers happen to be located in the system include
> directory, next to some system ICU headers (not bundled). If these are
> built before nodejs is, nodejs will get confused and try to use the
> system ICU headers instead of the bundled ones.
> Fix this by always using host-icu.
> Set CXXFLAGS to -DU_DISABLE_RENAMING=1 when building with
> system-icu since host-icu is built with --disable-renaming.
> Fixes:
> - http://autobuild.buildroot.net/results/1ef947553ec762dba6a6202b1cfc84ceed75dbb2/
> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
Committed to 2020.02.x and 2020.05.x, thanks.
--
Bye, Peter Korsgaard
prev parent reply other threads:[~2020-08-13 16:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-27 11:51 [Buildroot] [PATCH v7 1/1] package/nodejs: use system-icu for host-nodejs James Hilliard
2020-07-27 12:27 ` Yann E. MORIN
2020-08-13 16:44 ` Peter Korsgaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878sei7axk.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox