Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] Makefile: Fix overlay overwriting everything
Date: Thu, 11 Feb 2016 23:26:41 +0100	[thread overview]
Message-ID: <878u2qq3xa.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <56BB98E1.4070008@mind.be> (Arnout Vandecappelle's message of "Wed, 10 Feb 2016 21:09:05 +0100")

>>>>> "Arnout" == Arnout Vandecappelle <arnout@mind.be> writes:

Hi,

>> Solution:
 >> Telling rsync to treat symlinked dir on the receiver side as directory
 >> allow users to be blissfully ignorant of that problem.

 >  I'm not so sure of this one... It makes it impossible to override the symlinks
 > in the skeleton in the overlay. Say, you want to populate /var/spool with some
 > directories so it becomes useable.

 >  That said, it's probably better in that case to override the skeleton directly,
 > so that package installation can pick up the new directory.

 >  Still, you _are_ breaking a valid use case with this patch.

 >  What do the others think?

I'm also not really happy about it either. Another potential issue is if
the build machine is so old that rsync doesn't support --keep-dirlinks,
but according to:

https://download.samba.org/pub/unpacked/rsync/OLDNEWS

This was added in 2.6.3 (Sep 2004), so I guess even RHEL5 and similar
should have it.

-- 
Bye, Peter Korsgaard

  parent reply	other threads:[~2016-02-11 22:26 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-10 15:58 [Buildroot] [PATCH] Makefile: Fix overlay overwriting everything Maxime Hadjinlian
2016-02-10 20:09 ` Arnout Vandecappelle
2016-02-10 20:16   ` Maxime Hadjinlian
2016-02-10 20:35     ` Arnout Vandecappelle
2016-02-11  9:10       ` Maxime Hadjinlian
2016-02-11 22:26   ` Peter Korsgaard [this message]
2016-02-12 13:40     ` Maxime Hadjinlian
2016-06-02 22:20 ` Yann E. MORIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878u2qq3xa.fsf@dell.be.48ers.dk \
    --to=peter@korsgaard.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox