Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] Fix TARGET_PATH variable with external toolchain
Date: Sat, 24 Oct 2009 22:22:22 +0200	[thread overview]
Message-ID: <878wf0zgn5.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <1256413962.28475.115.camel@coalu.atr> (Lionel Landwerlin's message of "Sat\, 24 Oct 2009 21\:52\:42 +0200")

>>>>> "Lionel" == Lionel Landwerlin <llandwerlin@gmail.com> writes:

 Lionel> First let me argue that when buildroot is not using an external
 Lionel> toolchain, the $(STAGING_DIR)/bin and $(STAGING_DIR)/usr/bin
 Lionel> paths are a part of the TARGET_PATH variable.

Hmm, you're right - what a mess. There's no good reason why these should
be different in the regard.

 Lionel> The script returns paths relative to the host. This is going to
 Lionel> be a problem when linking the webkit binaries because the
 Lionel> linker will have to deal with host binaries... That's the same
 Lionel> kind of problem we are fixing with the libtool patch.

Yes, but copying the script from staging to host shouldn't change that.

 Lionel> I'm wondering whether adding the following to package/webkit/webkit.mk
 Lionel> should fix the problem :

 Lionel> WEBKIT_CONF_ENV = icu_config=$(STAGING_DIR)/usr/bin/icu-config

If the webkit configure script handles that (didn't check), then that
would certainly be the easiest/cleanest solution.

-- 
Bye, Peter Korsgaard

  reply	other threads:[~2009-10-24 20:22 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-24  0:04 [Buildroot] [PATCH] Fix TARGET_PATH variable with external toolchain Lionel Landwerlin
2009-10-24 18:37 ` Peter Korsgaard
2009-10-24 19:52   ` Lionel Landwerlin
2009-10-24 20:22     ` Peter Korsgaard [this message]
2009-10-25 13:52       ` Lionel Landwerlin
2009-10-27  7:44   ` Thomas Petazzoni
2009-10-27  9:45     ` Lionel Landwerlin
2009-10-27  9:53       ` Thomas Petazzoni
2009-10-27 10:17         ` Lionel Landwerlin
2009-10-27 16:36           ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878wf0zgn5.fsf@macbook.be.48ers.dk \
    --to=jacmet@uclibc.org \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox