From: "Alex Bennée" <alex.bennee@linaro.org>
To: Bernd Kuhls <bernd@kuhls.net>
Cc: buildroot@uclibc.org
Subject: Re: [Buildroot] [PATCH 8/8] package/vkmark: add vkmark benchmarking tool
Date: Wed, 04 Dec 2024 14:36:03 +0000 [thread overview]
Message-ID: <87a5dbbjn0.fsf@draig.linaro.org> (raw)
In-Reply-To: <pan$195e7$fd7fefb7$b25efed4$ee4a9dda@ID-313208.user.individual.net> (Bernd Kuhls's message of "Wed, 04 Dec 2024 08:42:10 +0100")
Bernd Kuhls <bernd@kuhls.net> writes:
> Am Tue, 03 Dec 2024 23:07:52 +0000 schrieb Alex Bennée:
>
>> This was already fixed in:
>>
>> Subject: [PATCH 0/2] Enable venus and add vkmark Date: Mon, 2 Dec
>> 2024 18:20:59 +0000 Message-Id:
>> <20241202182101.410320-1-alex.bennee@linaro.org>
>
> Hi Alex,
>
> these errors were not fixed by your updated patch:
>
> package/vkmark/Config.in:26: attributes order: type, default,
> depends on, select, help (https://nightly.buildroot.org/#_config_files)
>
> package/vkmark/Config.in:29: attributes order: type, default,
> depends on, select, help
> (https://nightly.buildroot.org/#_config_files)
What test detects these?
I ran:
utils/docker-run make check-package
and that was clean.
>
> Also the dependency
>
> depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9
>
> can be dropped because
>
> depends on BR2_TOOLCHAIN_GCC_AT_LEAST_7 # assimp
>
> exists.
>
> The dependency
>
> depends on BR2_INSTALL_LIBSTDCPP
>
> is present twice.
Fixed.
> Should !BR2_USE_WCHAR be added to the comment?
How do you mean? We need wchar.
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2024-12-04 14:36 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-02 19:06 [Buildroot] [PATCH 1/8] package/libdrm: add host variant Bernd Kuhls
2024-12-02 19:06 ` [Buildroot] [PATCH 2/8] package/llvm-project/libclc: " Bernd Kuhls
2024-12-02 19:06 ` [Buildroot] [PATCH 3/8] package/spirv-llvm-translator: add target variant to provide LLVMSPIRVLib Bernd Kuhls
2024-12-02 19:06 ` [Buildroot] [PATCH 4/8] package/spirv-tools: add host variant Bernd Kuhls
2024-12-02 19:06 ` [Buildroot] [PATCH 5/8] package/wayland-protocols: bump version to 1.38 Bernd Kuhls
2024-12-02 19:06 ` [Buildroot] [PATCH 6/8] package/{mesa3d, mesa3d-headers}: bump version to 24.3.0 Bernd Kuhls
2024-12-03 9:22 ` Andy Yan
2024-12-02 19:06 ` [Buildroot] [PATCH 7/8] package/mesa3d: add option to enable VIRTIO vulkan driver Bernd Kuhls
2024-12-02 19:06 ` [Buildroot] [PATCH 8/8] package/vkmark: add vkmark benchmarking tool Bernd Kuhls
2024-12-03 21:57 ` Julien Olivain
2024-12-03 23:07 ` Alex Bennée
[not found] ` <87ldwwbc1j.fsf__10394.9673286238$1733267303$gmane$org@draig.linaro.org>
2024-12-04 7:42 ` Bernd Kuhls
2024-12-04 14:36 ` Alex Bennée [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a5dbbjn0.fsf@draig.linaro.org \
--to=alex.bennee@linaro.org \
--cc=bernd@kuhls.net \
--cc=buildroot@uclibc.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox