From: Peter Korsgaard <peter@korsgaard.com>
To: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
Cc: Fabrice Fontaine <fontaine.fabrice@gmail.com>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Julien Boibessot <julien.boibessot@armadeus.com>
Subject: Re: [Buildroot] [PATCH 1/1] package/gpm: fix musl build with gcc 14
Date: Wed, 07 Aug 2024 00:15:13 +0200 [thread overview]
Message-ID: <87a5hpqowe.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20240712171541.07e8b250@windsurf> (Thomas Petazzoni via buildroot's message of "Fri, 12 Jul 2024 17:15:41 +0200")
>>>>> "Thomas" == Thomas Petazzoni via buildroot <buildroot@buildroot.org> writes:
> On Sat, 18 May 2024 11:17:07 +0200
> Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
>> Fix the following musl build failure with gcc 14:
>>
>> daemon/old_main.c: In function 'old_main':
>> daemon/old_main.c:56:11: error: implicit declaration of function 'strcmp' [-Wimplicit-function-declaration]
>> 56 | if(!strcmp((which_mouse->opt_dev),"-")) fd=0; /* use stdin */
>> | ^~~~~~
>> daemon/old_main.c:35:1: note: include '<string.h>' or provide a declaration of 'strcmp'
>> 34 | #include "headers/gpmInt.h" /* daemon internals */
>> +++ |+#include <string.h>
>> 35 |
>>
>> While at it, add Upstream tags to other patches
>>
>> Fixes:
>> - http://autobuild.buildroot.org/results/3192740863d57e72e90e622683e7b9fcc057fa8b
>>
>> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
>> ---
>> .checkpackageignore | 6 -----
>> ...usl-support-to-libgpm-and-the-daemon.patch | 4 +--
>> .../0002-Install-unversioned-solibrary.patch | 4 +--
>> ...Really-install-unversioned-solibrary.patch | 3 +--
>> ...mptyset-API-instead-of-__sigemptyset.patch | 1 +
>> .../gpm/0005-fix-building-w-newer-glibc.patch | 1 +
>> ...on.h-avoid-redefinition-of-last_sele.patch | 1 +
>> package/gpm/0007-Add-include-string-h.patch | 27 +++++++++++++++++++
>> 8 files changed, 33 insertions(+), 14 deletions(-)
>> create mode 100644 package/gpm/0007-Add-include-string-h.patch
> Applied to master, thanks.
Committed to 2024.05.x, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2024-08-06 22:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-18 9:17 [Buildroot] [PATCH 1/1] package/gpm: fix musl build with gcc 14 Fabrice Fontaine
2024-07-12 15:15 ` Thomas Petazzoni via buildroot
2024-08-06 22:15 ` Peter Korsgaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a5hpqowe.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@buildroot.org \
--cc=fontaine.fabrice@gmail.com \
--cc=julien.boibessot@armadeus.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox