From: Peter Korsgaard <peter@korsgaard.com>
To: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Fabrice Fontaine <fontaine.fabrice@gmail.com>,
Adam Duskett <aduskett@gmail.com>,
buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v2, 1/1] package/vulkan-loader: fix x11 handling
Date: Sun, 04 Feb 2024 22:25:13 +0100 [thread overview]
Message-ID: <87a5ofx6py.fsf@48ers.dk> (raw)
In-Reply-To: <Za_jnMEzxoboGoJA@landeda> (Yann E. MORIN's message of "Tue, 23 Jan 2024 17:04:44 +0100")
>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:
> Fabrice, All,
> On 2023-09-21 18:48 +0200, Fabrice Fontaine spake thusly:
>> Fix the following build failure raised since the addition of the package
>> in commit 6aa1bc31678ff9f8013084fda34b9f941cc63fc3:
>>
>> In file included from /home/buildroot/autobuild/run/instance-3/output-1/build/vulkan-loader-1.3.262/loader/extension_manual.h:24,
>> from /home/buildroot/autobuild/run/instance-3/output-1/build/vulkan-loader-1.3.262/loader/extension_manual.c:23:
>> /home/buildroot/autobuild/run/instance-3/output-1/host/aarch64-buildroot-linux-gnu/sysroot/usr/include/vulkan/vulkan.h:71:10: fatal error: X11/extensions/Xrandr.h: No such file or directory
>> 71 | #include <X11/extensions/Xrandr.h>
>> | ^~~~~~~~~~~~~~~~~~~~~~~~~
>>
>> Fixes:
>> - http://autobuild.buildroot.org/results/55ddfd44393e3bcc2f25bad2f9ecb7e1b142a985
>>
>> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> Applied to master, thanks.
> Your commits always contain the description of the failure (which is
> mildly interesting), but often lacks the actual reason for the change.
> In this case, it would have been interesting to state that xcb and xlib
> support are orthogonal, but that for xlib, xrandr is also required, as
> Adam noticed in his commit log [0].
Committed to 2023.11.x, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2024-02-04 21:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-21 16:48 [Buildroot] [PATCH v2, 1/1] package/vulkan-loader: fix x11 handling Fabrice Fontaine
2024-01-22 22:46 ` Adam Duskett
2024-01-23 16:04 ` Yann E. MORIN
2024-02-04 21:25 ` Peter Korsgaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a5ofx6py.fsf@48ers.dk \
--to=peter@korsgaard.com \
--cc=aduskett@gmail.com \
--cc=buildroot@buildroot.org \
--cc=fontaine.fabrice@gmail.com \
--cc=yann.morin.1998@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox