Re: [Buildroot] [PATCH v4 1/1] package/flutter-sdk-bin/Config.in.host: change flutter-pub-cache location

[Peter Korsgaard <peter@korsgaard.com>]

>>>>> "Adam" == Adam Duskett <adam.duskett@amarulasolutions.com> writes:

 > When running the command "flutter pub get," the plugins are stored in the
 > pub-cache directory along with their sha256sum hashes. The default location of
 > the pub-cache directory is current $(HOST_DIR)/share/flutter/sdk/.pub-cache,
 > which is not an acceptable choice by default because every plugin is
 > re-downloaded during every build of a flutter application either during a new
 > build or when building with the per-package-directory option enabled.

 > Furthermore, keeping the pub-cache in its current location prevents users from
 > committing the pub-cache directory to git for faster rebuilds of a
 > Buildroot-based system, as users cannot store the pub-cache for later use.

 > To fix the above issue completely, the following two changes must occur:

 >   - Change the hard-coded Flutter pub-cache location to
 >     $(DL_DIR)/br-flutter-pub-cache.

 >   - Remove the `rm -rf $(HOST_FLUTTER_SDK_BIN_SDK)/.pub-cache` and the
 >     associated comment about why the build system removes the .pub-cache
 >     directory. After further research, the help text of the precache command
 >     reads, "Populate the Flutter tool's cache of binary artifacts."
 >     The current reasoning listed in the comments is not accurate for a
 >     the following reasons:

 >     1. We do not want to remove their directory if users already have a pub
 >        cache they have symlinked to.

 >     2. If the flutter-sdk-bin package previously set up the pub-cache, then
 >        the pub-cache directory is set up with the options we want, and there
 >        is no reason to remove the pub-cache directory.

 > Signed-off-by: Adam Duskett <adam.duskett@amarulasolutions.com>
 > ---
 > changes v3 -> v4:
 >   - Hardcode the directory to $(DL_DIR)/br-flutter-pub-cache. [Yann]
 >   - Remove the `rm -rf $(HOST_FLUTTER_SDK_BIN_SDK)/.pub-cache` line. [Yann]
 >   - Remove the associated comments about the above line. [Yann]
 >   - Expand the commit log.

Committed to 2023.11.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot