From: Peter Korsgaard <peter@korsgaard.com>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: Gilles Talis <gilles.talis@gmail.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/faad2: force arm mode instead of Thumb mode
Date: Fri, 26 Jan 2024 22:33:35 +0100 [thread overview]
Message-ID: <87a5or230w.fsf@48ers.dk> (raw)
In-Reply-To: <20240126173215.1630553-1-fontaine.fabrice@gmail.com> (Fabrice Fontaine's message of "Fri, 26 Jan 2024 18:32:15 +0100")
>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:
> Fix the following build failure in Thumb mode:
> /tmp/ccfzn6FH.s:36: Error: selected processor does not support `smull r2,r3,r1,r0' in Thumb mode
> Fixes:
> - http://autobuild.buildroot.org/results/838808b4751244ee01cde6b8261212b49e511a32
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> package/faad2/faad2.mk | 7 +++++++
> 1 file changed, 7 insertions(+)
> diff --git a/package/faad2/faad2.mk b/package/faad2/faad2.mk
> index 686e5045c0..0e66ebc8e1 100644
> --- a/package/faad2/faad2.mk
> +++ b/package/faad2/faad2.mk
> @@ -12,4 +12,11 @@ FAAD2_CPE_ID_VENDOR = audiocoding
> FAAD2_CPE_ID_PRODUCT = freeware_advanced_audio_decoder_2
> FAAD2_INSTALL_STAGING = YES
> +# faad2 has some assembly function that are not present in thumb1 mode:
> +# Error: selected processor does not support `smull r2,r3,r1,r0' in Thumb mode
> +# so, we desactivate thumb mode
> +ifeq ($(BR2_ARM_INSTRUCTIONS_THUMB),y)
> +FAAD2_CONF_OPTS += -DCMAKE_C_FLAGS="$(TARGET_CFLAGS) -marm"
> +endif
Committed after rewording this slightly, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2024-01-26 21:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-26 17:32 [Buildroot] [PATCH 1/1] package/faad2: force arm mode instead of Thumb mode Fabrice Fontaine
2024-01-26 21:33 ` Peter Korsgaard [this message]
2024-02-28 13:39 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a5or230w.fsf@48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@buildroot.org \
--cc=fontaine.fabrice@gmail.com \
--cc=gilles.talis@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox