From: Peter Korsgaard <peter@korsgaard.com>
To: Romain Naour <romain.naour@gmail.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 2/2] package/localedef: build issue with old glibc (<= 2.38)
Date: Fri, 29 Sep 2023 21:33:25 +0200 [thread overview]
Message-ID: <87a5t4g4fu.fsf@48ers.dk> (raw)
In-Reply-To: <20230911210917.1114974-2-romain.naour@gmail.com> (Romain Naour's message of "Mon, 11 Sep 2023 23:09:17 +0200")
>>>>> "Romain" == Romain Naour <romain.naour@gmail.com> writes:
> While building host-localedef from glibc 2.38 sources, it uses the
> features.h header from it sources that define _ISOC2X_SOURCE 1 as
> soon as _GNU_SOURCE is defined.
> _ISOC2X_SOURCE enable __GLIBC_USE_ISOC2X 1 that enable the header
> redirection to use __isoc23_* functions introduced in glibc 2.38 [1].
> If an older version is installed on the host, thoses functions
> doesn't exist and break the build.
> Add a local patch to keep _ISOC2X_SOURCE and __GLIBC_USE_ISOC2X
> disabled.
> Fixes:
> host-localedef-2.38-13-g92201f16cbcfd9eafe314ef6654be2ea7ba25675/build/locale/ld-ctype.o:
> in function `ctype_read':
> ld-ctype.c:(.text+0x6cef): undefined reference to `__isoc23_strtoul'
> (glibc 2.31 installed on the host)
> [1]
> https://sourceware.org/git/?p=glibc.git;a=commit;h=64924422a99690d147a166b4de3103f3bf3eaf6c
> Signed-off-by: Romain Naour <romain.naour@gmail.com>
Committed, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2023-09-29 19:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-11 21:09 [Buildroot] [PATCH 1/2] package/{glibc, localedef}: bump to version 2.38-13-g92201f16cbcfd9eafe314ef6654be2ea7ba25675 Romain Naour
2023-09-11 21:09 ` [Buildroot] [PATCH 2/2] package/localedef: build issue with old glibc (<= 2.38) Romain Naour
2023-09-29 19:33 ` Peter Korsgaard [this message]
2023-09-29 19:32 ` [Buildroot] [PATCH 1/2] package/{glibc, localedef}: bump to version 2.38-13-g92201f16cbcfd9eafe314ef6654be2ea7ba25675 Peter Korsgaard
2023-09-30 13:48 ` Romain Naour
[not found] ` <87edigg4hb.fsf__32334.269203578$1696015980$gmane$org@48ers.dk>
2023-09-30 20:08 ` Bernd Kuhls
2023-09-30 20:59 ` Peter Korsgaard
2023-10-02 19:53 ` Bernd Kuhls
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a5t4g4fu.fsf@48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@buildroot.org \
--cc=romain.naour@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox