Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Baruch Siach via buildroot <buildroot@buildroot.org>
To: buildroot@busybox.net
Subject: Re: [Buildroot] [PATCH] package/socat: support OpenSSL only
Date: Thu, 10 Nov 2022 12:15:53 +0200	[thread overview]
Message-ID: <87a64zumuk.fsf@tarshish> (raw)
In-Reply-To: <3e8e93e9eed117bc7e49580fd77e254eee237a99.1668060990.git.baruch@tkos.co.il>

Hi Buildroot list,

On Thu, Nov 10 2022, Baruch Siach wrote:
> socat is not compatible with libressl.
>
> Fixes:
> http://autobuild.buildroot.net/results/6f0204004c52f762d6e3cb3064238d7eb3646038/

This issue only shows up in the 'next' branch where we have socat
version 1.7.4.4 which includes upstream commit 15e38be2f52 ("Fixed
SIGSEGV of OpenSSL on exit()") that exposes the issue. The (unused)
reference to OPENSSL_INIT_SETTINGS is there even in the previous 1.7.4.3
version that is in 'master'.

Note though that this patch applies to 'next', but conflicts with commit
934ec83e9d0 ("package/socat: disable openssl for static build") in
'master'. If this patch is applied to 'next' it will cause conflict when
'next' merges into 'master'.

Let me know if you want a patch against 'master' instead.

baruch

>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> ---
>  package/socat/socat.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/package/socat/socat.mk b/package/socat/socat.mk
> index 0414c8adc855..639b3d302847 100644
> --- a/package/socat/socat.mk
> +++ b/package/socat/socat.mk
> @@ -31,7 +31,7 @@ SOCAT_DEPENDENCIES = host-autoconf
>  # incompatibile license (GPL-3.0+)
>  SOCAT_CONF_OPTS = --disable-readline
>  
> -ifeq ($(BR2_PACKAGE_OPENSSL),y)
> +ifeq ($(BR2_PACKAGE_LIBOPENSSL),y)
>  SOCAT_DEPENDENCIES += openssl
>  else
>  SOCAT_CONF_OPTS += --disable-openssl


-- 
                                                     ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2022-11-10 10:26 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-10  6:16 [Buildroot] [PATCH] package/socat: support OpenSSL only Baruch Siach via buildroot
2022-11-10 10:15 ` Baruch Siach via buildroot [this message]
2022-11-11 22:50 ` Thomas Petazzoni via buildroot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a64zumuk.fsf@tarshish \
    --to=buildroot@buildroot.org \
    --cc=baruch@tkos.co.il \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox