Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/ply: build needs flex and bison
Date: Thu, 25 Feb 2021 20:30:52 +0100	[thread overview]
Message-ID: <87a6rsvtar.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20210223180435.GA30395@arbad> (Andreas Klinger's message of "Tue, 23 Feb 2021 19:04:37 +0100")

>>>>> "Andreas" == Andreas Klinger <ak@it-klinger.de> writes:

 > Building needs flex and bison installed on the host system.
 > Fixes:
 > http://autobuild.buildroot.net/results/7cfe75725f4746367f2870ee9545f31ba56f6ec1

 > Signed-off-by: Andreas Klinger <ak@it-klinger.de>
 > ---
 >  package/ply/ply.mk | 1 +
 >  1 file changed, 1 insertion(+)

 > diff --git a/package/ply/ply.mk b/package/ply/ply.mk
 > index 0e4141f650..e627a9181f 100644
 > --- a/package/ply/ply.mk
 > +++ b/package/ply/ply.mk
 > @@ -10,5 +10,6 @@ PLY_AUTORECONF = YES
 >  PLY_LICENSE = GPL-2.0
 >  PLY_LICENSE_FILES = COPYING
 >  PLY_INSTALL_STAGING = YES
 > +PLY_DEPENDENCIES += host-flex host-bison

We normally don't use += when it is the only assignment done to the
variable. Committed with that fixed, thanks.

-- 
Bye, Peter Korsgaard

      reply	other threads:[~2021-02-25 19:30 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-23 18:04 [Buildroot] [PATCH] package/ply: build needs flex and bison Andreas Klinger
2021-02-25 19:30 ` Peter Korsgaard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a6rsvtar.fsf@dell.be.48ers.dk \
    --to=peter@korsgaard.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox