From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2] package/meson: fix shared build issue due to --static flag always passed to pkg-config
Date: Mon, 13 Jul 2020 08:51:42 +0200 [thread overview]
Message-ID: <87a703lxfl.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20200614125002.3476208-1-romain.naour@gmail.com> (Romain Naour's message of "Sun, 14 Jun 2020 14:50:02 +0200")
>>>>> "Romain" == Romain Naour <romain.naour@gmail.com> writes:
> Since cf75d7da98596580eee5a9b5e1a3e156ad832099 we have a build failures when
> building libgbm.so when valgrind package is selected because --static is always
> passed to pkg-config even for shared build.
> Even if -Dvalgrind=false on meson command line to build mesa, the valgrind
> libraries come from pkg-config libdrm...
> output/host/bin/pkg-config libdrm --libs --static
> -L[...]/sysroot/usr/lib -ldrm -lm -L[...]/sysroot/usr/lib/valgrind
> -lcoregrind-arm64-linux -lvex-arm64-linux -lgcc
> ... and break the build.
> See initial discussions:
> http://lists.busybox.net/pipermail/buildroot/2020-June/284543.html
> This is due to a wrong condition test added by the patch
> 0004-mesonbuild-dependencies-base.py-add-pkg_config_stati.patch.
> Use None instead of False when pkg_config_static is not set, indeed
> pkg_config_static is a string not a boolean. But pkg_config_static is
> alsways set to 'true' or 'flase' in our meson package infra.
NIT: get returns None by default, so we don't need to explicitly pass
it.
Committed to 2020.02.x and 2020.05.x, thanks.
--
Bye, Peter Korsgaard
prev parent reply other threads:[~2020-07-13 6:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-14 12:50 [Buildroot] [PATCH v2] package/meson: fix shared build issue due to --static flag always passed to pkg-config Romain Naour
2020-06-14 14:15 ` Yann E. MORIN
2020-07-13 6:51 ` Peter Korsgaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a703lxfl.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox