From mboxrd@z Thu Jan 1 00:00:00 1970 From: Baruch Siach Date: Thu, 07 Mar 2019 17:10:52 +0200 Subject: [Buildroot] [PATCH v2 1/4] package/optee-client: depends on thread support In-Reply-To: <1551970132-9377-1-git-send-email-etienne.carriere@linaro.org> References: <17603738bfac0de04a1de57a562dbde2a572d926.1551944208.git.etienne.carriere@linaro.org> <1551970132-9377-1-git-send-email-etienne.carriere@linaro.org> Message-ID: <87a7i63ekj.fsf@tarshish> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net Hi Etienne, On Thu, Mar 07 2019, Etienne Carriere wrote: > BR2_PACKAGE_OPTEE_CLIENT depends on BR2_TOOLCHAIN_HAS_THREADS. > Library teec uses pthread support to protect clients state > management. This change declares this dependency in the package. > > Fixes [1] and [2] where config selected an toolchain without thread > support and build failed with trace like: > > CMake Error at /home/buildroot/autobuild/run/instance-1/output/host/share/cmake-3.8/Modules/FindPackageHandleStandardArgs.cmake:137 (message): > Could NOT find Threads (missing: Threads_FOUND) > Call Stack (most recent call first): > /home/buildroot/autobuild/run/instance-1/output/host/share/cmake-3.8/Modules/FindPackageHandleStandardArgs.cmake:377 (_FPHSA_FAILURE_MESSAGE) > /home/buildroot/autobuild/run/instance-1/output/host/share/cmake-3.8/Modules/FindThreads.cmake:212 (FIND_PACKAGE_HANDLE_STANDARD_ARGS) > libteec/CMakeLists.txt:8 (find_package) > > [1] http://autobuild.buildroot.net/results/ed6ffe2197da4f3a970bd3c5522291236396cc8e > [2] http://autobuild.buildroot.net/results/406f90048db097580b626ef889823132f8676ba1 > > Signed-off-by: Etienne Carriere > --- > Changes v1 -> v2: > - No change. v2 appends changes to this change to propagate the optee-client > dependency on threads to packages dependent on optee-client. All patches in this series should be squashed into a single patch. Otherwise the build is broken between patch #1 and others. This hurts the so called bisectability of git history. In addition, this patch (and others) are missing update to dependencies comments to account for the added dependency. baruch > --- > package/optee-client/Config.in | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/package/optee-client/Config.in b/package/optee-client/Config.in > index db0b7b7..1379201 100644 > --- a/package/optee-client/Config.in > +++ b/package/optee-client/Config.in > @@ -1,6 +1,7 @@ > config BR2_PACKAGE_OPTEE_CLIENT > bool "optee-client" > depends on !BR2_STATIC_LIBS > + depends on BR2_TOOLCHAIN_HAS_THREADS > help > Enable the OP-TEE client package that brings non-secure > client application resources for OP-TEE support. OP-TEE -- http://baruch.siach.name/blog/ ~. .~ Tk Open Systems =}------------------------------------------------ooO--U--Ooo------------{= - baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -