Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/systemd: fix "Timed out waiting for device /dev/console."
Date: Sun, 03 Mar 2019 22:21:14 +0100	[thread overview]
Message-ID: <87a7ibk62d.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20190303204826.GL2721@scaer> (Yann E. MORIN's message of "Sun, 3 Mar 2019 21:48:26 +0100")

>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:

Hi,

 >> I was going to commit this, but then I noticed that there isn't a
 >> console-getty at .service file, so this doesn't seem right:
 >> 
 >> ls -lah ../../../../lib/systemd/system/|grep getty
 >> lrwxrwxrwx 1 peko peko 49 Mar 3 21:13 autovt at .service ->
 >> ../../../../usr/lib/systemd/system/getty at .service
 >> -rw-r--r--  1 peko peko 1.1K Mar  3 21:13 console-getty.service

 >> -rw-r--r--  1 peko peko 1.2K Mar  3 21:13 container-getty at .service
 >> -rw-r--r--  1 peko peko  506 Dec 21 19:53 getty-pre.target
 >> -rw-r--r--  1 peko peko 1.8K Mar  3 21:13 getty at .service
 >> -rw-r--r--  1 peko peko  500 Dec 21 19:53 getty.target
 >> -rw-r--r--  1 peko peko 1.5K Mar  3 21:13 serial-getty at .service
 >> 
 >> I guess we need to introduce a TARGET variable that is
 >> $${SERVICE}.service for console-getty, and $${SERVICE}@.service for
 >> everything else, but I know next to nothing about systemd, so I will let
 >> someone who can actually test this send a patch.

 > Well, wecould make it simple, and use (pseudoc-ode):

 >     if console:
 >         SERVICE='console-getty'
 >     elif vt:
 >         SERVICE='getty@'
 >     else:
 >         SERVICE='serial-getty@'

 > No?

I don't think so, as we need both <name>@<target> and <target>:

	ln -fs ../../../../lib/systemd/system/$${SERVICE}@.service \
		$(TARGET_DIR)/etc/systemd/system/getty.target.wants/$${SERVICE}@$(BR2_TARGET_GENERIC_GETTY_PORT).service

So we either end up with no @ in the symlink name, or a double @@.

I don't know if that is problem or not for systemd.

-- 
Bye, Peter Korsgaard

  reply	other threads:[~2019-03-03 21:21 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-03 11:30 [Buildroot] [PATCH 1/1] package/systemd: fix "Timed out waiting for device /dev/console." Xavier Ruppen
2019-03-03 11:54 ` Yann E. MORIN
2019-03-03 20:26   ` Peter Korsgaard
2019-03-03 20:48     ` Yann E. MORIN
2019-03-03 21:21       ` Peter Korsgaard [this message]
2019-03-03 21:37         ` Yann E. MORIN
2019-03-03 21:55           ` Xavier Ruppen
2019-03-03 20:04 ` [Buildroot] [PATCH v2 " Xavier Ruppen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a7ibk62d.fsf@dell.be.48ers.dk \
    --to=peter@korsgaard.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox