[Buildroot] [PATCH v5 04/10] testing/tests/download: add git hash test

[Peter Korsgaard <peter@korsgaard.com>]

>>>>> "Arnout" == Arnout Vandecappelle <arnout@mind.be> writes:

Hi,

 >>> Shouldn't we add a timeout here, just to be safe?
 >> 
 >> I think the expect() method uses the default from the class if not defined.
 >> And the default timeout for spawn is 30 seconds AFAICR.
 >> I did not double-checked the docs yet.

 >  I had only diagonally read the documentation and I saw that timeout in expect()
 > defaults to -1, so I assumed it was infinity... But in fact it indeed means
 > "inherit from the spawn class", and there it defaults to 30.

I got confused by that as well when I wrote the docker/compose
tests.

Notice that we set timeout to 5 in emulator.py:

   timeout=5 * self.timeout_multiplier

So I believe -1 means 5 seconds, not 30.

-- 
Bye, Peter Korsgaard