Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] fs/common.mk: enable multithreaded xz compression
Date: Sun, 27 Jan 2019 23:06:14 +0100	[thread overview]
Message-ID: <87a7jln4bt.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20190126150622.23c7375e@windsurf> (Thomas Petazzoni's message of "Sat, 26 Jan 2019 15:06:22 +0100")

>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@bootlin.com> writes:

 > Hello,
 > On Mon, 21 Jan 2019 18:39:24 +0100, Peter Korsgaard wrote:

 >> > I thought it was using the version compiled by buildroot.
 >> > Isn't that what host-xz is being used for?  
 >> 
 >> Yes, correct. Do you know if the -T 0 option generates identical output
 >> as -T 1? Otherwise we may want to disable it for reproducible builds.

 > Does it matter than the output of -T 0 and -T 1 are identical ?

It would cause an extra change in output between buildroot versions
using -T 0 and ones using -T 1 - But OK, probably that isn't really
important given all the other changes.

What I really meant was if the -T 1 option affected the output format,
and if so, if the difference involved any tradeoff (E.G. perhaps -T 1
compresses slightly worse than -T 0) and if repeated runs with -T 1
would generate the same output (on same machine or on another machine
with different number of threads).

 > What matters for BR2_REPRODUCIBLE=y is if the same input, with -T 0,
 > always provide the exact identical output.

With the new patch that only enables -T 1 for !reproducible builds,
that is correct.

-- 
Bye, Peter Korsgaard

  parent reply	other threads:[~2019-01-27 22:06 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-21  2:07 [Buildroot] [PATCH 1/1] fs/common.mk: enable multithreaded xz compression james.hilliard1 at gmail.com
2019-01-21 14:02 ` Matthew Weber
2019-01-21 14:05   ` James Hilliard
2019-01-21 14:28     ` [Buildroot] [External] " Matthew Weber
2019-01-21 17:39     ` [Buildroot] " Peter Korsgaard
2019-01-21 21:34       ` James Hilliard
2019-01-26 14:06       ` Thomas Petazzoni
2019-01-26 19:31         ` James Hilliard
2019-01-27 22:06         ` Peter Korsgaard [this message]
2019-01-27 22:15           ` James Hilliard
2019-01-27 22:18           ` Peter Korsgaard
2019-01-28  8:23           ` Thomas Petazzoni
2019-01-28  8:25             ` James Hilliard
2019-01-28  8:57             ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a7jln4bt.fsf@dell.be.48ers.dk \
    --to=peter@korsgaard.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox