From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] imx-gpu-viv: add a missing backslash
Date: Fri, 20 Jul 2018 13:47:21 +0200 [thread overview]
Message-ID: <87a7qm86ye.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20180720131639.373130b0@windsurf> (Thomas Petazzoni's message of "Fri, 20 Jul 2018 13:16:39 +0200")
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@bootlin.com> writes:
Hi,
>> A semicolon is also missing. I've changed it to do '|| exit 1; \' like
>> we do elsewhere to catch failures and committed, thanks.
> Actually, in this sort of case, I would prefer to use a make for loop:
> $(foreach lib,egl gbm glesv1_cm glesv2 vg, \
> ln -sf $(lib)_x11.pc $(@D)/gpu-core/usr/lib/pkgconfig/$(lib).pc
> )
> make automatically aborts the loop if there's an error, and $(lib) is
> more readable than $${lib}.
Correct. I left it like this as the file has several other shell loops.
--
Bye, Peter Korsgaard
next prev parent reply other threads:[~2018-07-20 11:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-20 9:16 [Buildroot] [PATCH 1/1] imx-gpu-viv: add a missing backslash Laurent Hartanerot
2018-07-20 9:42 ` Peter Korsgaard
2018-07-20 11:16 ` Thomas Petazzoni
2018-07-20 11:47 ` Peter Korsgaard [this message]
2018-07-20 21:31 ` Peter Korsgaard
[not found] <20180720091038.24853-1-laurent.hartanerot@gmail.com>
2018-07-20 9:23 ` Gary Bisson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a7qm86ye.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox