Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/5] xr819-firmware: new package
Date: Sun, 05 Nov 2017 12:53:47 +0100	[thread overview]
Message-ID: <87a8012b78.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20171104194049.24550-2-geomatsi@gmail.com> (Sergey Matyukevich's message of "Sat, 4 Nov 2017 22:40:45 +0300")

>>>>> "Sergey" == Sergey Matyukevich <geomatsi@gmail.com> writes:

 > Add firmware for XR819 SDIO WiFi chip.

Thanks. I had a quick look at doing so myself some time ago, but never
got around to finishing it.

> +++ b/package/xr819-firmware/xr819-firmware.mk
 > @@ -0,0 +1,25 @@
 > +################################################################################
 > +#
 > +# xr819-firmware
 > +#
 > +################################################################################
 > +
 > +XR819_FIRMWARE_VERSION = v2017.07
 > +XR819_FIRMWARE_SITE =  https://github.com/armbian/build/raw/$(XR819_FIRMWARE_VERSION)/packages/extras/firmware/xr819
 > +XR819_FIRMWARE_SOURCE = fw_xr819.bin
 > +XR819_FIRMWARE_EXTRA_DOWNLOADS = boot_xr819.bin sdd_xr819.bin
 > +XR819_FIRMWARE_LICENSE = PROPRIETARY

These firmware blobs are quite icky. If I understand correctly, the
firmware comes from some kind of (android?) disk image. Given that, I'm
not sure we are really allowed to redistribute them so we should set
XR819_FIRMWARE_REDISTRIBUTE = NO

The fact that the filenames are not versioned is also a pain, as we
cannot really handle any future version bumps without breaking older
releases.

I agree that cloning the huge armbian build repo for these small files
isn't really nice, but I had a look at the armbian github and I see they
have recently moved the firmware blobs to a separate repo:

https://github.com/armbian/firmware

Which is only around ~9MB, so I suggest we download that with git
similar to linux-firmware, then at least we have a git revision.

Care to rework the package to be such an "armbian-firmware" package
instead? For now it is fine to just have a single sub option to install
the xr819 files.

-- 
Bye, Peter Korsgaard

  reply	other threads:[~2017-11-05 11:53 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-04 19:40 [Buildroot] [PATCH 0/5] orangepi-zero: misc updates Sergey Matyukevich
2017-11-04 19:40 ` [Buildroot] [PATCH 1/5] xr819-firmware: new package Sergey Matyukevich
2017-11-05 11:53   ` Peter Korsgaard [this message]
2017-11-05 15:39     ` Sergey Matyukevich
2017-11-05 16:33       ` Yann E. MORIN
2017-11-04 19:40 ` [Buildroot] [PATCH 2/5] orange-pi-zero: add xr819 firmware Sergey Matyukevich
2017-11-04 19:40 ` [Buildroot] [PATCH 3/5] orange-pi-zero: bump kernel version Sergey Matyukevich
2017-11-05 19:08   ` Peter Korsgaard
2017-11-04 19:40 ` [Buildroot] [PATCH 4/5] package/xr819-xradio: update to the latest version Sergey Matyukevich
2017-11-05 19:07   ` Peter Korsgaard
2017-11-04 19:40 ` [Buildroot] [PATCH 5/5] DEVELOPERS: add myself to several packages Sergey Matyukevich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a8012b78.fsf@dell.be.48ers.dk \
    --to=peter@korsgaard.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox