Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [git commit] toolchain-external: adjust musl dynamic linker symlink for mips-sf
@ 2017-05-30  9:39 Thomas Petazzoni
  2017-06-01 14:38 ` Peter Korsgaard
  0 siblings, 1 reply; 2+ messages in thread
From: Thomas Petazzoni @ 2017-05-30  9:39 UTC (permalink / raw)
  To: buildroot

commit: https://git.buildroot.net/buildroot/commit/?id=a6a4a8b2ef1fa747fdc79bc7bae0518417910f5d
branch: https://git.buildroot.net/buildroot/commit/?id=refs/heads/master

The external toolchain code has some logic to calculate the correct name
for the dynamic linker symbolic link that needs to be created when the
musl C library is being used. There was already some handling for the
mipsel+soft-float case, but not for the mips+soft-float case. Due to
this, the symbolic link was incorrectly named, and programs were
referencing an non-existing file.

Reported-by: Florent Jacquet <florent.jacquet@free-electrons.com>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
---
 toolchain/toolchain-external/pkg-toolchain-external.mk | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/toolchain/toolchain-external/pkg-toolchain-external.mk b/toolchain/toolchain-external/pkg-toolchain-external.mk
index 9670350..856be65 100644
--- a/toolchain/toolchain-external/pkg-toolchain-external.mk
+++ b/toolchain/toolchain-external/pkg-toolchain-external.mk
@@ -481,6 +481,8 @@ ifeq ($(BR2_i386),y)
 MUSL_ARCH = i386
 else ifeq ($(BR2_ARM_EABIHF),y)
 MUSL_ARCH = armhf
+else ifeq ($(BR2_mips):$(BR2_SOFT_FLOAT),y:y)
+MUSL_ARCH = mips-sf
 else ifeq ($(BR2_mipsel):$(BR2_SOFT_FLOAT),y:y)
 MUSL_ARCH = mipsel-sf
 else ifeq ($(BR2_sh),y)

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [Buildroot] [git commit] toolchain-external: adjust musl dynamic linker symlink for mips-sf
  2017-05-30  9:39 [Buildroot] [git commit] toolchain-external: adjust musl dynamic linker symlink for mips-sf Thomas Petazzoni
@ 2017-06-01 14:38 ` Peter Korsgaard
  0 siblings, 0 replies; 2+ messages in thread
From: Peter Korsgaard @ 2017-06-01 14:38 UTC (permalink / raw)
  To: buildroot

>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:

 > commit: https://git.buildroot.net/buildroot/commit/?id=a6a4a8b2ef1fa747fdc79bc7bae0518417910f5d
 > branch: https://git.buildroot.net/buildroot/commit/?id=refs/heads/master

 > The external toolchain code has some logic to calculate the correct name
 > for the dynamic linker symbolic link that needs to be created when the
 > musl C library is being used. There was already some handling for the
 > mipsel+soft-float case, but not for the mips+soft-float case. Due to
 > this, the symbolic link was incorrectly named, and programs were
 > referencing an non-existing file.

 > Reported-by: Florent Jacquet <florent.jacquet@free-electrons.com>
 > Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>

Committed to 2017.02.x, thanks.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-06-01 14:38 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-05-30  9:39 [Buildroot] [git commit] toolchain-external: adjust musl dynamic linker symlink for mips-sf Thomas Petazzoni
2017-06-01 14:38 ` Peter Korsgaard

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox