From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/racehound: fix comment
Date: Wed, 13 Apr 2016 00:00:48 +0200 [thread overview]
Message-ID: <87a8kylc6n.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <1460481650-19136-1-git-send-email-yann.morin.1998@free.fr> (Yann E. MORIN's message of "Tue, 12 Apr 2016 19:20:50 +0200")
>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:
> racehound requires a kernel >= 3.14 to be built and to run.
> However, the current conditions on the corresponding comments are wrong:
> - the comment about the kernel has a dependency on the requested
> headers
> - the comment on the toolchain features does not have this condition.
> Thus, the comments are not shown/hidden under the appropriate
> conditions, like in this situation:
> - toolchain with headers < 3.14 (e.g. Sourcery CodeBench x86/x86_64
> 2012.09 with headers 3.5)
> - kernel 4.5 enabled
> this comment is shown:
> racehound needs an Linux kernel >= 3.14 to be built
> So, this is incorrect, because:
> 1- a kernel >= 3.14 is indeed to be built
> 2- the headers version mismatch is not reported
> Fix that by moving the dependency on the kernel headers to the
> appropriate comment and enhance it.
> Since there is no way we can know the kernel version to be built, we can
> not add such a condition; still, we leave the kernel message as-is.
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Committed, thanks.
--
Bye, Peter Korsgaard
next prev parent reply other threads:[~2016-04-12 22:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-12 17:20 [Buildroot] [PATCH] package/racehound: fix comment Yann E. MORIN
2016-04-12 21:27 ` Arnout Vandecappelle
2016-04-12 22:02 ` Peter Korsgaard
2016-04-13 20:18 ` Yann E. MORIN
2016-04-13 20:42 ` Arnout Vandecappelle
2016-04-14 17:09 ` Yann E. MORIN
2016-04-12 22:00 ` Peter Korsgaard [this message]
2016-04-12 22:04 ` Arnout Vandecappelle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a8kylc6n.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox