Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2] apitrace: new package
Date: Fri, 10 Jan 2014 23:55:42 +0100	[thread overview]
Message-ID: <87a9f378gh.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <1388698061-32942-1-git-send-email-jezz@sysmic.org> ("Jérôme Pouiller"'s message of "Thu, 2 Jan 2014 22:27:40 +0100")

>>>>> "J?r?me" == J?r?me Pouiller <jezz@sysmic.org> writes:

 > Trace and replay OpenGL and OpenGL ES APIs calls to/from a file.
 > http://apitrace.github.io/

 > Signed-off-by: J?r?me Pouiller <jezz@sysmic.org>
 > ---
 > v2:
 >  Fix dependencies problems (identified by Samuel)

 >  package/Config.in            |  1 +
 >  package/apitrace/Config.in   | 14 ++++++++++++++
 >  package/apitrace/apitrace.mk | 17 +++++++++++++++++
 >  3 files changed, 32 insertions(+)
 >  create mode 100644 package/apitrace/Config.in
 >  create mode 100644 package/apitrace/apitrace.mk

 > diff --git a/package/Config.in b/package/Config.in
 > index 1ee60c1..097b487 100644
 > --- a/package/Config.in
 > +++ b/package/Config.in
 > @@ -216,6 +216,7 @@ source "package/weston/Config.in"
 
 >  comment "X applications"
 >  source "package/alsamixergui/Config.in"
 > +source "package/apitrace/Config.in"
 >  source "package/docker/Config.in"
 >  source "package/feh/Config.in"
 >  source "package/freerdp/Config.in"
 > diff --git a/package/apitrace/Config.in b/package/apitrace/Config.in
 > new file mode 100644
 > index 0000000..388b3e9
 > --- /dev/null
 > +++ b/package/apitrace/Config.in
 > @@ -0,0 +1,14 @@
 > +comment "apitrace needs a toolchain w/ C++"
 > +	depends on !BR2_INSTALL_LIBSTDCPP

This comment should also depend on _XORG7 so it only shows up if X11
support is enabled.

 > +
 > +config BR2_PACKAGE_APITRACE
 > +	bool "apitrace"
 > +	depends on BR2_PACKAGE_XORG7
 > +	depends on BR2_INSTALL_LIBSTDCPP
 > +	select BR2_PACKAGE_XLIB_LIBX11
 > +	help
 > +	  Trace and replay OpenGL and OpenGL ES APIs calls to/from a file. You 
 > +	  may install apitrace GUI from your distribution to inspect generated 
 > +	  traces.
 > +	  
 > +	  http://apitrace.github.io/

Some trailing spaces and too long help text lines.

I did a test build on uClibc which failed because it tries to use the
glibc specific __libc_dlsym symbol, so I made the package depend on
BR2_TOOLCHAIN_USES_GLIBC.

 > diff --git a/package/apitrace/apitrace.mk b/package/apitrace/apitrace.mk
 > new file mode 100644
 > index 0000000..c31a5b3
 > --- /dev/null
 > +++ b/package/apitrace/apitrace.mk
 > @@ -0,0 +1,17 @@
 > +################################################################################
 > +#
 > +# apitrace
 > +#
 > +################################################################################
 > +
 > +APITRACE_VERSION = c181b7fbf4b1c3912424761fec8ac7124640543a
 > +APITRACE_SITE = http://github.com/apitrace/apitrace/tarball/$(APITRACE_VERSION)

I've changed it to use the github helper.

Committed with these changes, thanks.

-- 
Bye, Peter Korsgaard

      parent reply	other threads:[~2014-01-10 22:55 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-02 21:27 [Buildroot] [PATCH v2] apitrace: new package Jérôme Pouiller
2014-01-02 22:20 ` Jerzy Grzegorek
2014-01-03  9:01   ` Jérôme Pouiller
2014-01-03  9:05     ` Baruch Siach
2014-01-10 22:55 ` Peter Korsgaard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a9f378gh.fsf@dell.be.48ers.dk \
    --to=jacmet@uclibc.org \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox