From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] New package liblog4c-localtime
Date: Sun, 21 Oct 2012 21:10:27 +0200 [thread overview]
Message-ID: <87a9vftzdo.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <1349948066-12255-1-git-send-email-fenixk19@mail.ru> (Alexander Varnin's message of "Thu, 11 Oct 2012 13:34:26 +0400")
>>>>> "Alexander" == Alexander Varnin <fenixk19@mail.ru> writes:
Alexander> Signed-off-by: Alexander Varnin <fenixk19@mail.ru>
Thanks, committed with minor fixes (see below).
Alexander> +++ b/package/liblog4c-localtime/Config.in
Alexander> @@ -0,0 +1,10 @@
Alexander> +config BR2_PACKAGE_LIBLOG4C_LOCALTIME
Alexander> + bool "liblog4c-localtime"
You forgot to select BR2_PACKAGE_EXPAT.
Alexander> + help
Alexander> + Log4c is a library of C for flexible logging to files, syslog
Please no trailing spaces.
Alexander> + and other destinations.
Alexander> + This version is with localtime patch, to make lib show times in
Alexander> + local timezone.
Alexander> +
Alexander> + https://github.com/rcmadruga/log4c-localtime
Alexander> + http://log4c.sourceforge.net/
This should be indented with <tab><space><space> like the rest.
Alexander> diff --git a/package/liblog4c-localtime/liblog4c-localtime.mk b/package/liblog4c-localtime/liblog4c-localtime.mk
Alexander> new file mode 100644
Alexander> index 0000000..0aedec8
Alexander> --- /dev/null
Alexander> +++ b/package/liblog4c-localtime/liblog4c-localtime.mk
Alexander> @@ -0,0 +1,18 @@
Alexander> + #############################################################
Alexander> + #
Alexander> + # liblog4c
Alexander> + #
Alexander> + #############################################################
Alexander> + LIBLOG4C_LOCALTIME_VERSION = 1.0
Alexander> + LIBLOG4C_LOCALTIME_SITE = https://github.com/rcmadruga/log4c-localtime/tarball/v$(LIBLOG4C_LOCALTIME_VERSION)
Please no trailing spaces.
Alexander> + LIBLOG4C_LOCALTIME_INSTALL_STAGING = YES
Alexander> + LIBLOG4C_LOCALTIME_CONF_OPT = --disable-expattest
Alexander> + LIBLOG4C_LOCALTIME_DEPENDENCIES = expat
Alexander> +
Alexander> + define LIBLOG4C_LOCALTIME_HOOK
Alexander> + chmod +x $(@D)/configure
Alexander> + endef
Alexander> +
Alexander> + LIBLOG4C_LOCALTIME_PRE_CONFIGURE_HOOKS += LIBLOG4C_LOCALTIME_HOOK
Please don't indent this. I renamed this hook to
LIBLOG4C_LOCALTIME_FIX_CONFIGURE_PERMS to make it clear what it does.
--
Bye, Peter Korsgaard
next prev parent reply other threads:[~2012-10-21 19:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-11 9:34 [Buildroot] [PATCH] New package liblog4c-localtime Alexander Varnin
2012-10-21 19:10 ` Peter Korsgaard [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-10-08 6:56 Alexander Varnin
2012-10-09 20:29 ` Arnout Vandecappelle
2012-10-11 9:17 ` Alexander Varnin
2012-10-11 9:20 ` Arnout Vandecappelle
2012-10-04 9:08 Alexander Varnin
2012-10-04 9:10 ` Alexander Varnin
2012-10-04 9:24 ` Samuel Martin
2012-10-04 13:36 ` Thomas Petazzoni
2012-10-05 19:47 ` Arnout Vandecappelle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a9vftzdo.fsf@macbook.be.48ers.dk \
--to=jacmet@uclibc.org \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox