From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] sdl_gfx: don't use --enable-mmx on x86_64
Date: Sun, 14 Oct 2012 20:51:46 +0200 [thread overview]
Message-ID: <87a9vozy2l.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <1350240476-22608-1-git-send-email-thomas.petazzoni@free-electrons.com> (Thomas Petazzoni's message of "Sun, 14 Oct 2012 20:47:56 +0200")
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:
Thomas> Even though the MMX instructions are available on x86_64 processors,
Thomas> the MMX code in sdl_gfx is written in IA32-specific assembly code, and
Thomas> therefore does not build on x86_64. It generates the following build
Thomas> issues:
Thomas> SDL_imageFilter.c: Assembler messages:
Thomas> SDL_imageFilter.c:34: Error: `pusha' is not supported in 64-bit mode
Thomas> SDL_imageFilter.c:38: Error: `popa' is not supported in 64-bit mode
Thomas> SDL_imageFilter.c:77: Error: `pusha' is not supported in 64-bit mode
Thomas> SDL_imageFilter.c:93: Error: `popa' is not supported in 64-bit mode
Thomas> [...]
Thomas> We fix this by only enabling MMX support in this package when the
Thomas> processor supports MMX *and* it is a IA32 compatible processor.
Thomas> Fixes
Thomas> http://autobuild.buildroot.org/results/b9efc611f5da487079b6be37bb7a41a3198d63b9/
Committed, thanks.
--
Bye, Peter Korsgaard
prev parent reply other threads:[~2012-10-14 18:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-14 18:47 [Buildroot] [PATCH] sdl_gfx: don't use --enable-mmx on x86_64 Thomas Petazzoni
2012-10-14 18:51 ` Peter Korsgaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a9vozy2l.fsf@macbook.be.48ers.dk \
--to=jacmet@uclibc.org \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox