Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 40/74] dmraid: remove useless strip and use correct step override method
Date: Sun, 12 Sep 2010 23:35:37 +0200	[thread overview]
Message-ID: <87aanmk5li.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <020e028108d53c14ae257c8a643aa2d22ac00f4a.1284312638.git.thomas.petazzoni@free-electrons.com> (Thomas Petazzoni's message of "Sun, 12 Sep 2010 19:42:26 +0200")

>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:

 Thomas> For the target installation step, do not rely on the package being
 Thomas> installed in the staging directory, as it may not be true. So the
 Thomas> dmraid binary is directly taken from the build directory.

 Thomas> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
 Thomas> ---
 Thomas>  package/dmraid/dmraid.mk |   24 +++++++-----------------
 Thomas>  1 files changed, 7 insertions(+), 17 deletions(-)

 Thomas> diff --git a/package/dmraid/dmraid.mk b/package/dmraid/dmraid.mk
 Thomas> index 93d6561..ccd6a36 100644
 Thomas> --- a/package/dmraid/dmraid.mk
 Thomas> +++ b/package/dmraid/dmraid.mk
 Thomas> @@ -12,23 +12,13 @@ DMRAID_MAKE = $(MAKE1)
 Thomas>  DMRAID_DEPENDENCIES:=lvm2
 Thomas>  DMRAID_INSTALL_STAGING:=yes
 
 Thomas> -$(eval $(call AUTOTARGETS,package,dmraid))
 Thomas> -
 Thomas> -$(DMRAID_TARGET_INSTALL_TARGET): $(DMRAID_TARGET_INSTALL_STAGING)
 Thomas> -	$(call MESSAGE,"Installing to target")
 Thomas> -	$(INSTALL) -m 0755 $(STAGING_DIR)/usr/sbin/dmraid $(TARGET_DIR)/usr/sbin
 Thomas> +define DMRAID_INSTALL_TARGET_CMDS
 Thomas> +	$(INSTALL) -m 0755 $(@D)/$(DMRAID_SUBDIR)/tools/dmraid $(TARGET_DIR)/usr/sbin
 Thomas>  	$(INSTALL) -m 0755 package/dmraid/dmraid.init $(TARGET_DIR)/etc/init.d/dmraid

Again - Not your fault, but the init scripts need so be named S??dmraid
for the default rcS handler to find it. The init script furthermore
expects dmraid to be installed in /sbin but we're installing into
/usr/sbin.

Care to fix this up while you're at it?

-- 
Bye, Peter Korsgaard

  reply	other threads:[~2010-09-12 21:35 UTC|newest]

Thread overview: 81+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-12 17:41 [Buildroot] [pull request] Pull request for branch for-2010.11/remove-oldstyle-hooks Thomas Petazzoni
2010-09-12 17:41 ` [Buildroot] [PATCH 01/74] bind: remove old-style hook usage and step override Thomas Petazzoni
2010-09-12 17:41 ` [Buildroot] [PATCH 02/74] libglade: convert old-style hook to new-style hook Thomas Petazzoni
2010-09-12 17:41 ` [Buildroot] [PATCH 03/74] tn5250: remove old-style hook usage and step override Thomas Petazzoni
2010-09-12 17:41 ` [Buildroot] [PATCH 04/74] avahi: convert old-style hook to new-style hook Thomas Petazzoni
2010-09-12 17:41 ` [Buildroot] [PATCH 05/74] libungif: " Thomas Petazzoni
2010-09-12 17:41 ` [Buildroot] [PATCH 06/74] libxslt: " Thomas Petazzoni
2010-09-12 17:41 ` [Buildroot] [PATCH 07/74] libevent: " Thomas Petazzoni
2010-09-12 17:41 ` [Buildroot] [PATCH 08/74] taglib: " Thomas Petazzoni
2010-09-12 17:41 ` [Buildroot] [PATCH 09/74] pango: " Thomas Petazzoni
2010-09-12 17:41 ` [Buildroot] [PATCH 10/74] samba: convert old-style hooks to new-style hooks Thomas Petazzoni
2010-09-12 17:41 ` [Buildroot] [PATCH 11/74] php: " Thomas Petazzoni
2010-09-12 17:41 ` [Buildroot] [PATCH 12/74] libidn: " Thomas Petazzoni
2010-09-12 17:41 ` [Buildroot] [PATCH 13/74] jpeg: " Thomas Petazzoni
2010-09-12 17:42 ` [Buildroot] [PATCH 14/74] sdl_sound: " Thomas Petazzoni
2010-09-12 21:23   ` Peter Korsgaard
2010-09-12 17:42 ` [Buildroot] [PATCH 15/74] freetype: " Thomas Petazzoni
2010-09-12 17:42 ` [Buildroot] [PATCH 16/74] shared-mime-info: convert old-style hook to new-style hook Thomas Petazzoni
2010-09-12 17:42 ` [Buildroot] [PATCH 17/74] mysql_client: " Thomas Petazzoni
2010-09-12 17:42 ` [Buildroot] [PATCH 18/74] usbutils: " Thomas Petazzoni
2010-09-12 21:30   ` Peter Korsgaard
2010-09-12 17:42 ` [Buildroot] [PATCH 19/74] liboil: " Thomas Petazzoni
2010-09-12 17:42 ` [Buildroot] [PATCH 20/74] libcurl: convert old-style hook to new-style Thomas Petazzoni
2010-09-12 17:42 ` [Buildroot] [PATCH 21/74] libgtk2: " Thomas Petazzoni
2010-09-12 17:42 ` [Buildroot] [PATCH 22/74] dropbear: convert old-style hook and commands " Thomas Petazzoni
2010-09-12 17:42 ` [Buildroot] [PATCH 23/74] lite: convert old-style hook to new-style hook Thomas Petazzoni
2010-09-12 17:42 ` [Buildroot] [PATCH 24/74] libiconv: " Thomas Petazzoni
2010-09-12 17:42 ` [Buildroot] [PATCH 25/74] libpng: " Thomas Petazzoni
2010-09-12 17:42 ` [Buildroot] [PATCH 26/74] libdnet: " Thomas Petazzoni
2010-09-12 17:42 ` [Buildroot] [PATCH 27/74] libxml2: " Thomas Petazzoni
2010-09-12 17:42 ` [Buildroot] [PATCH 28/74] openssh: " Thomas Petazzoni
2010-09-12 17:42 ` [Buildroot] [PATCH 29/74] e2fsprogs: convert old-style hooks " Thomas Petazzoni
2010-09-12 17:42 ` [Buildroot] [PATCH 30/74] xlib_libX11: convert old-style hooks to new-style hooks Thomas Petazzoni
2010-09-12 17:42 ` [Buildroot] [PATCH 31/74] wpa_supplicant: " Thomas Petazzoni
2010-09-12 17:42 ` [Buildroot] [PATCH 32/74] squid: convert old-style hook to new-style hook Thomas Petazzoni
2010-09-12 17:42 ` [Buildroot] [PATCH 33/74] tiff: use correct construct to override target installation Thomas Petazzoni
2010-09-12 17:42 ` [Buildroot] [PATCH 34/74] bridge: remove useless strip and use correct definition for uninstall Thomas Petazzoni
2010-09-12 17:42 ` [Buildroot] [PATCH 35/74] at: convert old-style hook to new-style hook Thomas Petazzoni
2010-09-12 17:42 ` [Buildroot] [PATCH 36/74] oprofile: use correct way of overriding steps Thomas Petazzoni
2010-09-12 17:42 ` [Buildroot] [PATCH 37/74] ncftp: " Thomas Petazzoni
2010-09-12 17:42 ` [Buildroot] [PATCH 38/74] bmon: " Thomas Petazzoni
2010-09-12 17:42 ` [Buildroot] [PATCH 39/74] libnl: remove useless strip and use correct step override Thomas Petazzoni
2010-09-12 17:42 ` [Buildroot] [PATCH 40/74] dmraid: remove useless strip and use correct step override method Thomas Petazzoni
2010-09-12 21:35   ` Peter Korsgaard [this message]
2010-09-12 17:42 ` [Buildroot] [PATCH 41/74] alsa-lib: " Thomas Petazzoni
2010-09-12 17:42 ` [Buildroot] [PATCH 42/74] kismet: " Thomas Petazzoni
2010-09-12 17:42 ` [Buildroot] [PATCH 43/74] gawk: convert old-style hook to new-style hook Thomas Petazzoni
2010-09-12 17:42 ` [Buildroot] [PATCH 44/74] lighttpd: use correct step override method Thomas Petazzoni
2010-09-12 17:42 ` [Buildroot] [PATCH 45/74] netperf: " Thomas Petazzoni
2010-09-12 17:42 ` [Buildroot] [PATCH 46/74] hostapd: " Thomas Petazzoni
2010-09-12 17:42 ` [Buildroot] [PATCH 47/74] sqlite: " Thomas Petazzoni
2010-09-12 17:42 ` [Buildroot] [PATCH 48/74] nano: " Thomas Petazzoni
2010-09-12 17:42 ` [Buildroot] [PATCH 49/74] openntpd: " Thomas Petazzoni
2010-09-12 17:42 ` [Buildroot] [PATCH 50/74] prboom: use correctly the autotargets infrastructrure Thomas Petazzoni
2010-09-12 17:42 ` [Buildroot] [PATCH 51/74] mdadm: use correct step override method Thomas Petazzoni
2010-09-12 17:42 ` [Buildroot] [PATCH 52/74] less: " Thomas Petazzoni
2010-09-12 17:42 ` [Buildroot] [PATCH 53/74] iptables: convert old-style hook to new-style hook Thomas Petazzoni
2010-09-12 17:42 ` [Buildroot] [PATCH 54/74] openvpn: use correct step override method Thomas Petazzoni
2010-09-12 17:42 ` [Buildroot] [PATCH 55/74] ntfsprogs: " Thomas Petazzoni
2010-09-12 17:42 ` [Buildroot] [PATCH 56/74] dbus: convert old-style hook to new-style hook Thomas Petazzoni
2010-09-12 17:42 ` [Buildroot] [PATCH 57/74] docker: remove useless post install stripping hook Thomas Petazzoni
2010-09-12 17:42 ` [Buildroot] [PATCH 58/74] expat: " Thomas Petazzoni
2010-09-12 17:42 ` [Buildroot] [PATCH 59/74] gvfs: convert to new style hook, remove useless stripping Thomas Petazzoni
2010-09-12 17:42 ` [Buildroot] [PATCH 60/74] haserl: convert to new style hook Thomas Petazzoni
2010-09-12 17:42 ` [Buildroot] [PATCH 61/74] ifplugd: " Thomas Petazzoni
2010-09-12 17:42 ` [Buildroot] [PATCH 62/74] kexec: " Thomas Petazzoni
2010-09-12 17:42 ` [Buildroot] [PATCH 63/74] libpcap: remove useless stripping Thomas Petazzoni
2010-09-12 17:42 ` [Buildroot] [PATCH 64/74] metacity: use new style hook Thomas Petazzoni
2010-09-12 17:42 ` [Buildroot] [PATCH 65/74] speex: convert to " Thomas Petazzoni
2010-09-12 17:42 ` [Buildroot] [PATCH 66/74] nbd: use " Thomas Petazzoni
2010-09-12 17:42 ` [Buildroot] [PATCH 67/74] neon: remove useless stripping Thomas Petazzoni
2010-09-12 17:42 ` [Buildroot] [PATCH 68/74] pcre: convert to new style hook Thomas Petazzoni
2010-09-12 17:42 ` [Buildroot] [PATCH 69/74] radvd: " Thomas Petazzoni
2010-09-12 17:42 ` [Buildroot] [PATCH 70/74] strace: " Thomas Petazzoni
2010-09-12 17:42 ` [Buildroot] [PATCH 71/74] tcpdump: remove useless stripping Thomas Petazzoni
2010-09-12 17:42 ` [Buildroot] [PATCH 72/74] udpcast: actually use the hooks Thomas Petazzoni
2010-09-12 17:42 ` [Buildroot] [PATCH 73/74] which: remove useless stripping Thomas Petazzoni
2010-09-12 17:43 ` [Buildroot] [PATCH 74/74] infrastructure: remove support for old style hooks Thomas Petazzoni
2010-09-16 11:37 ` [Buildroot] [pull request] Pull request for branch for-2010.11/remove-oldstyle-hooks Peter Korsgaard
2010-09-16 12:14   ` Thomas Petazzoni
2010-09-16 12:31     ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87aanmk5li.fsf@macbook.be.48ers.dk \
    --to=jacmet@uclibc.org \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox