Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] svn commit: trunk/buildroot/package: multimedia/mpg123
Date: Sat, 24 Jan 2009 12:48:28 +0100	[thread overview]
Message-ID: <87ab9ghqlv.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <20090124112748.D8336769CC@busybox.osuosl.org> (ulf@uclibc.org's message of "Sat\, 24 Jan 2009 11\:27\:48 +0000 \(UTC\)")

>>>>> "ulf" == ulf  <ulf@uclibc.org> writes:

 ulf> Author: ulf
 ulf> Date: 2009-01-24 11:27:47 +0000 (Sat, 24 Jan 2009)
 ulf> New Revision: 25004

 ulf> Log:
 ulf> Make toolchain configration to fix mpg123 global and move to Makefile

 ulf> Modified:
 ulf>    trunk/buildroot/package/Makefile.in
 ulf>    trunk/buildroot/package/multimedia/mpg123/Config.in
 ulf>    trunk/buildroot/package/multimedia/mpg123/mpg123-0.66-arm-unroll.patch
 
 ulf> +# Handle bug fixes in toolchain
 ulf> +ifeq ($(BR2_arm),y)
 ulf> +ifeq ($(BR2_GCC_VERSION_4_3_2),y)
 ulf> +# Removes segment violation in mpg123.

Confusing comments as It's a GCC ICE, not mpg123 crashing.

What about the other gcc 4.3.x versions? Does it E.G. also occur with
4.3.1?

Why isn't this in mpg123.mk ?

 ulf> -+#if	defined(MPG123_ARM_UNROLL_FIX)
 ulf> ++#if	defined(ARM_UNROLL_FIX)

Why the rename?

-- 
Bye, Peter Korsgaard

  reply	other threads:[~2009-01-24 11:48 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-24 11:27 [Buildroot] svn commit: trunk/buildroot/package: multimedia/mpg123 ulf at uclibc.org
2009-01-24 11:48 ` Peter Korsgaard [this message]
  -- strict thread matches above, loose matches on Subject: below --
2009-02-05 13:24 jacmet at uclibc.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ab9ghqlv.fsf@macbook.be.48ers.dk \
    --to=jacmet@uclibc.org \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox