From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] svn commit: trunk/buildroot/package: pixman x11r7
Date: Tue, 26 Aug 2008 21:27:57 +0200 [thread overview]
Message-ID: <87abez8tky.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <20080826162725.ACBE63C8AA@busybox.net> (laird@uclibc.org's message of "Tue\, 26 Aug 2008 09\:27\:25 -0700 \(PDT\)")
>>>>> "laird" == laird <laird@uclibc.org> writes:
laird> Author: laird
laird> Date: 2008-08-26 09:27:25 -0700 (Tue, 26 Aug 2008)
laird> New Revision: 23210
laird> Log:
laird> Move pixman from package/x11r7/pixman to package/pixman
laird> Means we can now bounce cairo to 1.6.x series.
laird> pixman is not dependant on x libraries what so over so removed
laird> the dependencies section.
It could be cool if you styled your commits like:
pixman: move from package/x11r7/ to package/
Pixmand doesn't depend on X libraries, so move it out of x11r7 and
remove the X dependencies.
Then you can see right away what the commit is about in git-shortlog.
laird> PIXMAN_VERSION = 0.10.0
laird> PIXMAN_SOURCE = pixman-$(PIXMAN_VERSION).tar.gz
laird> PIXMAN_SITE = http://cairographics.org/releases/
laird> @@ -12,6 +11,4 @@
laird> PIXMAN_INSTALL_STAGING_OPT = DESTDIR=$(STAGING_DIR) install install-data
laird> PIXMAN_INSTALL_TARGET_OPT = DESTDIR=$(TARGET_DIR) install install-data
I know you didn't change the above 2 lines, but they look fishy. From
a quick look, it seems install-data only installs a subset of install,
so it's redundant. Also install-strip should be used for target to
strip the libs.
I've fixed it in r23211.
--
Bye, Peter Korsgaard
prev parent reply other threads:[~2008-08-26 19:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-26 16:27 [Buildroot] svn commit: trunk/buildroot/package: pixman x11r7 laird at uclibc.org
2008-08-26 19:27 ` Peter Korsgaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87abez8tky.fsf@macbook.be.48ers.dk \
--to=jacmet@uclibc.org \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox