From: Peter Korsgaard <peter@korsgaard.com>
To: Yegor Yefremov via buildroot <buildroot@buildroot.org>
Cc: Bernd Kuhls <bernd@kuhls.net>, Thomas Perale <thomas.perale@mind.be>
Subject: Re: [Buildroot] [PATCH] package/prboom: fix build with GCC 14
Date: Sat, 14 Nov 2026 10:40:23 +0100 [thread overview]
Message-ID: <87bj7rg394.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20261112100822.3298943-1-yegorslists@googlemail.com> (Yegor Yefremov via buildroot's message of "Thu, 12 Nov 2026 11:08:22 +0100")
>>>>> "Yegor" == Yegor Yefremov via buildroot <buildroot@buildroot.org> writes:
> Since autoconf 2.73, AC_PROG_CC enables C23 with -std=gnu23 when the
> compiler accepts it, which GCC 14 does. As prboom is autoreconfigured,
> it is then built in C23 mode, where false and true are keywords:
> ../../src/doomtype.h:48:15: error: expected identifier before 'false'
> 48 | typedef enum {false, true} boolean;
> | ^~~~~
> Commit 2eb72e7666 ("package/prboom: fix build w/ gcc-15") already
> forces -std=gnu18 to avoid this, but only for GCC >= 15, where C23 is
> the default. Apply it from GCC 14 on. With -std=gnu18 in CFLAGS, the
> configure C23 check fails and -std=gnu23 is no longer added.
> This issue has been present since commit a6e8c07a330a
> ("package/autoconf: bump version to 2.73"), as autoconf 2.72 never
> selected C23. It therefore affects 2026.08 and later. The 2026.05.x and
> older maintenance branches still use autoconf 2.72 and are not
> affected.
> Fixes:
> https://autobuild.buildroot.org/results/7d5050c54ba8319f0fd58336851121f5e127b1aa
> Fixes: a6e8c07a330a389e9578d8f1110e41becac264d2 ("package/autoconf: bump version to 2.73")
> Assisted-by: Claude:claude-opus-5-5
> Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
Committed, thanks.
Maybe the time has come to drop prboom? It is ancient and is also one of
the few packages using the old SDL (1.2.x) version.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2026-11-14 9:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-12 10:08 [Buildroot] [PATCH] package/prboom: fix build with GCC 14 Yegor Yefremov via buildroot
2026-11-14 9:40 ` Peter Korsgaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bj7rg394.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=bernd@kuhls.net \
--cc=buildroot@buildroot.org \
--cc=thomas.perale@mind.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox