Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <peter@korsgaard.com>
To: Thomas Devoogdt <thomas@devoogdt.com>
Cc: buildroot@buildroot.org,  Michael Fischer <mf@go-sys.de>,
	 Alexander Shiyan <eagle.alexander923@gmail.com>,
	 Thomas Devoogdt <thomas.devoogdt@barco.com>
Subject: Re: [Buildroot] [PATCH v2] package/sdl2: add wayland support
Date: Fri, 16 May 2025 17:52:47 +0200	[thread overview]
Message-ID: <87bjrsa6y8.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <87frh4a8le.fsf@dell.be.48ers.dk> (Peter Korsgaard's message of "Fri, 16 May 2025 17:17:17 +0200")

>>>>> "Peter" == Peter Korsgaard <peter@korsgaard.com> writes:

>>>>> "Thomas" == Thomas Devoogdt <thomas@devoogdt.com> writes:
 >> From: Thomas Devoogdt <thomas.devoogdt@barco.com>
 >> This adds a configuration option to enable the Wayland
 >> video driver support in SDL2.

 >> Signed-off-by: Thomas Devoogdt <thomas.devoogdt@barco.com>
 >> Tested-by: Alexander Shiyan <eagle.alexander923@gmail.com>
 >> ---
 >> v2:
 >> - Added tested sign-off, see https://patchwork.ozlabs.org/comment/3457513/.
 >> - Slightly changed the git message.
 >> ---
 >> package/sdl2/Config.in | 17 +++++++++++++++++
 >> package/sdl2/sdl2.mk   |  8 +++++++-
 >> 2 files changed, 24 insertions(+), 1 deletion(-)

 >> diff --git a/package/sdl2/Config.in b/package/sdl2/Config.in
 >> index f1c22e4f80..018e64a8d8 100644
 >> --- a/package/sdl2/Config.in
 >> +++ b/package/sdl2/Config.in
 >> @@ -22,6 +22,23 @@ comment "X11 video driver needs X.org"
 >> depends on !BR2_PACKAGE_XORG7
 >> depends on BR2_USE_MMU
 
 >> +config BR2_PACKAGE_SDL2_WAYLAND
 >> +	bool "Wayland video driver"
 >> +	depends on BR2_TOOLCHAIN_HAS_THREADS # wayland
 >> +	depends on BR2_PACKAGE_WAYLAND
 >> +	depends on BR2_PACKAGE_HAS_LIBEGL
 >> +	depends on BR2_PACKAGE_SDL2_OPENGLES
 >> +	select BR2_PACKAGE_LIBXKBCOMMON
 >> +	select BR2_PACKAGE_WAYLAND_PROTOCOLS
 >> +
 >> +comment "Wayland video driver needs a toolchain w/ threads"
 >> +	depends on !BR2_TOOLCHAIN_HAS_THREADS
 >> +
 >> +comment "Wayland video driver needs wayland with an OpenGLES+EGL backend"
 >> +	depends on !BR2_PACKAGE_WAYLAND || \
 >> +		!BR2_PACKAGE_HAS_LIBEGL || \
 >> +		!BR2_PACKAGE_SDL2_OPENGLES
 >> +
 >> config BR2_PACKAGE_SDL2_KMSDRM

 > Moved it after KMSDRM and applied, thanks.

Wait, you added the .mk logic in the middle of the BR2_PACKAGE_SDL2_X11
conditional so it only works if the X11 driver is enabled. I'll send a
fix.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2025-05-16 15:52 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-15  8:51 [Buildroot] (no subject) Luke D. Jones
2023-03-15  8:51 ` [Buildroot] [PATCH] package/sdl2: Add config for wayland, vivante, pulseaudio Luke D. Jones
2023-03-16 14:09   ` Luke Jones
2024-08-30 17:52   ` [Buildroot] [PATCH v1] package/sdl2: enable wayland support Thomas Devoogdt
2025-02-09 18:16     ` [Buildroot] [PATCH v2] package/sdl2: add " Thomas Devoogdt
2025-05-16 15:17       ` Peter Korsgaard
2025-05-16 15:52         ` Peter Korsgaard [this message]
2026-11-20 21:54   ` [Buildroot] [PATCH v2] package/sdl2: add PulseAudio support Angelo Compagnucci

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bjrsa6y8.fsf@dell.be.48ers.dk \
    --to=peter@korsgaard.com \
    --cc=buildroot@buildroot.org \
    --cc=eagle.alexander923@gmail.com \
    --cc=mf@go-sys.de \
    --cc=thomas.devoogdt@barco.com \
    --cc=thomas@devoogdt.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox